Re: Fix receive support in erl_eval with a BEAM module
Björn Gustavsson <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <CA+yh78Ru8-RM9aCw_ogNL_HBjYfOjqngqb5jGz1QyBdezRC6SA@mail.gmail.com> |
Clever surgery of prim_eval.beam! Looks good to me. Hidden like this, using BEAM assembly code is fine for me. From the outside, prim_eval:'receive'/2 looks like any other BIF (where BIF = "function implemented in C or Erlang included with the run-time system"). We will now test your patch for several days in our daily builds before graduating it. On Mon, May 13, 2013 at 9:15 PM, Anthony Ramine <[email protected]> wrote: > Done. Please refetch. > > -- > Anthony Ramine > > Le 13 mai 2013 à 16:50, Anthony Ramine a écrit : > > > Hello Fredrik, > > > > Fine with me but what about other files like leex.erl in parsetools > which is BSD licensed? > > > > Regards, > > > > -- > > Anthony Ramine > > > > Le 13 mai 2013 à 16:38, Fredrik a écrit : > > > >> On 05/06/2013 10:30 PM, Anthony Ramine wrote: > >>> Hello, > >>> > >>> Using the low-level BEAM instructions, we can loop over each message > in the process queue and removes the first message that matches, without > receiving them all to later send them back to itself. > >>> > >>> git fetch > >>> https://github.com/nox/otp.git > >>> erl_eval-receive > >>> > >>> > >>> https://github.com/nox/otp/compare/erlang:maint...erl_eval-receive > >>> > >>> > >>> > https://github.com/nox/otp/compare/erlang:maint...erl_eval-receive.patch > >>> > >>> > >>> Regards, > >>> > >>> > >> Hello Anthony, > >> You need to remove your "own" copyright text in > >> erts/preloaded/src/add_abstract_code > >> erts/preloaded/src/prim_eval.S > >> erts/preloaded/src/prim_eval.erl > >> > >> And replace this with ordinary Ericsson license. > >> > >> Thanks, > >> -- > >> > >> BR Fredrik Gustafsson > >> Erlang OTP Team > >> > > > > _______________________________________________ > erlang-patches mailing list > [email protected] > http://erlang.org/mailman/listinfo/erlang-patches > -- Björn Gustavsson, Erlang/OTP, Ericsson AB _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches