Re: Add processes state view in observer

Dan Gudmundsson <[email protected]>
Newsgroups gmane.comp.lang.erlang.patches
Message-ID <CANX4uuMH5hcmnRB1TK4+dmUhra8++3jwPPEA58ohyM+Ws7V6zA@mail.gmail.com>
Hi Eric

Some formality, can you please redo the branch to one commit or change the
commit message
for each commit, describing the changes in each commit.

The coding style must follow what is there previously,
i.e. %% for line comments
and no space before ';'

Either the page should be created dynamically when the state information is
available,
or a proper error message should be displayed, not a blank page.
Maybe {"Information", "Not available"}.

Also the io_lib:format("~-20.s ~p~n"... should maybe use ~tp to be able to
display
unicode strings in the state.

/Dan

On Mon, May 13, 2013 at 10:17 AM, Fredrik <[email protected]> wrote:

> On 05/10/2013 08:29 AM, PAILLEAU Eric wrote:
>
>> Hello,
>> I didn't see it before, but the indentation was messed up with
>> tabulations.
>> Please ask to gustehn to fetch again the last commit.
>> Sorry for the inconvenience.
>> Regards
>>
>>  Hello Eric,
>>> Your patch has been sent to a review process. You will get updated on
>>> the outcome of this.
>>> Thanks for your contribution!
>>>
>>>  Re-fetched.
> Thanks,
>
>
> --
>
> BR Fredrik Gustafsson
> Erlang OTP Team
>
> ______________________________**_________________
> erlang-patches mailing list
> [email protected]
> http://erlang.org/mailman/**listinfo/erlang-patches<http://erlang.org/mailman/listinfo/erlang-patches>
>

_______________________________________________
erlang-patches mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-patches
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.