Re: Properly ignore os_mon and otp_mibs generated includes
Anthony Ramine <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <[email protected]> |
Hello Fredrik, Regular expression "[A-Z]*" doesn't match OTP-OS-MON-MIB. Do you want me to amend my patch so it only modifies the top-level .gitignore to match on "[A-Z-]" instead of "[A-Z]"? On a side-note I hate top-level .gitignore files because you tend to forget their existence. Regards, -- Anthony Ramine Le 20 mai 2013 à 10:18, Fredrik a écrit : > On 05/09/2013 03:09 PM, Anthony Ramine wrote: >> Hello, >> >> git fetch >> https://github.com/nox/otp.git >> fix-ignore >> >> >> https://github.com/nox/otp/compare/erlang:maint...fix-wcwidth >> >> >> https://github.com/nox/otp/compare/erlang:maint...fix-wcwidth.patch >> >> >> Regards, >> >> > Hello Anthony, > Some questions raised when reviewing your patch, > > Isn't this already taken care of by $ERL_TOP/.gitignore: > > /lib/otp_mibs/include/[A-Z]*.hrl /lib/os_mon/include/[A-Z]*.hrl > > What you want to achieve in your patch should be handled in this gitignore. > Thanks, > > -- > > BR Fredrik Gustafsson > Erlang OTP Team > _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches