Re: make edlin understand a few important control keys

On 05/06/2013 02:53 PM, Stefan Zegenhagen wrote:
> Dear all,
>
> the patch attached to this e-mail teaches edlin.erl a few more important
> control keys that many users might have become *VERY* accustomed to. The
> control keys are:
>
>   -<CTRL>+W	: backward kill word
>   -<CTRL>+U	: backward kill line
>   -<HOME>	: goto start of line
>   -<END>	: goto end of line
>   -<CTRL>+<LEFT>   : backward word
>   -<CTRL>+<RIGHT>  : forward word
>
> With this patch in place, command line editing in erlang's own shell as
> well as in any input using io:get_line() comes a little closer to that
> in many contemporary shells.
>
>
> Kind regards,
>
>
>
> _______________________________________________
> erlang-patches mailing list
> [email protected]
> http://erlang.org/mailman/listinfo/erlang-patches
Hello Stefan,
I've gotten some feedback from your review,
You need to add documentation under Erts-> "User's Guide" -> "tty - A 
command line interface"

You need to add testcase in interactive_shell_SUITE a simplified example 
of how this testcase could look like;
ctrl_w_and_ctrl_u(_Conf) ->
     rtnode([{putline,""}, {putline, "2."}, {getline, "2"}, 
{putline,"xxx yy"++[$\^w]++"."}, {getline,"xxx"}, {putline,"xxx 
yy"++[$\^u]++"z."}, {getline,"z"}],[]).

-- 

BR Fredrik Gustafsson
Erlang OTP Team

_______________________________________________
erlang-patches mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-patches