Re: odbcserver crash fix
Fredrik <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <[email protected]> |
On 06/27/2013 08:13 AM, Sergei Golovan wrote: > Hi! > > Appears that odbcserver crashes if it's started with incorrect data on > its stdin. The following command leads to a segmentation fault: > > echo -en "\x0\x0\x0\x1\x0" | ./odbcserver > > The problem basically is tokenizing input using strtok() and not > checking for NULL after that. > > I don't think that it's a very serious bug (odbcserver is executed > only in odbc module and doesn't receive arbitrary input), but it'd be > better to have it fixed. > > I'd like to propose a small fix for it: > > git fetch git://github.com/sgolovan/otp.git odbcserver_crash_fix > > The diff and patch can be seen at > > https://github.com/sgolovan/otp/compare/erlang:maint...odbcserver_crash_fix > https://github.com/sgolovan/otp/compare/erlang:maint...odbcserver_crash_fix.patch > > -- > Sergei Golovan > _______________________________________________ > erlang-patches mailing list > [email protected] > http://erlang.org/mailman/listinfo/erlang-patches Hello Sergei, I've fetched your patch and it should soon be visible in the 'pu' branch. Thanks, -- BR Fredrik Gustafsson Erlang OTP Team _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches