Re: Add dict:is_empty/1 and orddict:is_empty/1

Looks good, for completeness can you add a test where it returns false too.



On Fri, Sep 6, 2013 at 1:20 PM, Richard Carlsson <[email protected]
> wrote:

> Perhaps I should mention my attempt at a complete unified dict-API, that I
> tried to rouse some interest in about a couple of years ago. (This change
> would be compatible with my suggestions.)
>
> See
>
> http://erlang.org/pipermail/**erlang-questions/2011-**December/063430.html<http://erlang.org/pipermail/erlang-questions/2011-December/063430.html>
>
> and
>
> https://github.com/richcarl/**otp/tree/dict-api<https://github.com/richcarl/otp/tree/dict-api>
>
>     /Richard
>
>
> On 2013-09-06 13:05 , Robert Virding wrote:
>
>> I just want to comment that I think this is a reasonable and useful
>> externsion of the dict/orddict API.
>>
>> Robert
>>
>> ----- Original Message -----
>>
>>> From: "Fredrik" <[email protected]>
>>> To: "Magnus Henoch" <[email protected]>
>>> Cc: [email protected]
>>> Sent: Wednesday, 4 September, 2013 4:22:14 PM
>>> Subject: Re: [erlang-patches] Add dict:is_empty/1 and orddict:is_empty/1
>>>
>>> On 09/04/2013 04:13 PM, Magnus Henoch wrote:
>>>
>>>> This patch adds the functions dict:is_empty/1 and orddict:is_empty/1.
>>>> For dict, comparing the size against 0 runs in constant time, but not
>>>> for orddict.  My new functions are an attempt to relieve users from
>>>> having to know such implementation details.
>>>>
>>>> git fetch git://github.com/legoscia/otp.**git<http://github.com/legoscia/otp.git>dict_orddict_is_empty
>>>>
>>>> https://github.com/legoscia/**otp/compare/erlang:master...**
>>>> legoscia:dict_orddict_is_empty<https://github.com/legoscia/otp/compare/erlang:master...legoscia:dict_orddict_is_empty>
>>>> https://github.com/legoscia/**otp/compare/erlang:master...**
>>>> legoscia:dict_orddict_is_**empty.patch<https://github.com/legoscia/otp/compare/erlang:master...legoscia:dict_orddict_is_empty.patch>
>>>>
>>>> Regards,
>>>> Magnus
>>>> ______________________________**_________________
>>>> erlang-patches mailing list
>>>> [email protected]
>>>> http://erlang.org/mailman/**listinfo/erlang-patches<http://erlang.org/mailman/listinfo/erlang-patches>
>>>>
>>> Hello Magnus,
>>> I've fetched your patch and assigned it to be reviewed by responsible
>>> developers.
>>> Thanks,
>>>
>>> --
>>>
>>> BR Fredrik Gustafsson
>>> Erlang OTP Team
>>>
>>> ______________________________**_________________
>>> erlang-patches mailing list
>>> [email protected]
>>> http://erlang.org/mailman/**listinfo/erlang-patches<http://erlang.org/mailman/listinfo/erlang-patches>
>>>
>>>  ______________________________**_________________
>> erlang-patches mailing list
>> [email protected]
>> http://erlang.org/mailman/**listinfo/erlang-patches<http://erlang.org/mailman/listinfo/erlang-patches>
>>
>>
> ______________________________**_________________
> erlang-patches mailing list
> [email protected]
> http://erlang.org/mailman/**listinfo/erlang-patches<http://erlang.org/mailman/listinfo/erlang-patches>
>

_______________________________________________
erlang-patches mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-patches