Re: The diameter_sctp module uses the incorrect type gen_sctp:open_option/0
Anders Svensson <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <CADho9ocbhJmyrHtkOC0PCnXGYyf1ZrEwFTawZ3n3mD+HmfoY_A@mail.gmail.com> |
gen_sctp:option() is not the type diameter_sctp wants. What it wants
is everything that gen_sctp:open/1 accepts; that is:
-type open_option() ::
{ip | ifaddr, inet:ip_address() | any | loopback} |
inet:address_family() |
{port, inet:port_number()} |
{type, socket_type()} |
option().
The non-trivial bit is updating the documentation accordingly.
/Anders, Erlang/OTP
On Mon, Sep 23, 2013 at 7:50 PM, Juan Jose Comellas <[email protected]> wrote:
> The diameter_sctp module uses the incorrect type gen_sctp:open_option/0 but
> its correct name is gen_sctp:open_option/0. This patch fixes this problem
> and has also been sent as a pull request.
>
> git fetch git://github.com/jcomellas/otp.git jc-gen_sctp-option
>
> https://github.com/jcomellas/otp/compare/erlang:maint...jc-gen_sctp-option
> https://github.com/jcomellas/otp/compare/erlang:maint...jc-gen_sctp-option.patch
>
> _______________________________________________
> erlang-patches mailing list
> [email protected]
> http://erlang.org/mailman/listinfo/erlang-patches
>
_______________________________________________
erlang-patches mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-patches