Re: [erlang-patches] Properly handle export_all when looking for undefined callbacks

Robert Virding <[email protected]>
Newsgroups gmane.comp.lang.erlang.bugs,gmane.comp.lang.erlang.patches
Message-ID <1028606425.371940.1383059237855.JavaMail.zimbra@erlang-solutions.com>
Sorry I missed this one earlier. Do you mean EVERY callback or just those which haven't been explicitly exported and have been left to the export_all? If it is the latter case then I wouldn't consider this an error. Functions which are meant to be seen on the outside of a module should be explicitly exported, export_all is more a development/debugging hack. IMAO anyway. If it the first case where having an export_all means that no callback is seen then it is a bug.

Robert

----- Original Message -----
> From: "Fredrik" <[email protected]>
> 
> On 10/12/2013 02:10 PM, Anthony Ramine wrote:
> > Hello,
> >
> > When compiling a behaviour with export_all, every callback is marked as
> > missing by erl_lint. This patch fixes this.
> >
> > Thanks to Michele Miron (Cc'd) for reporting this bug.
> >
> > 	git fetch https://github.com/nox/otp.git export_all-behaviour
> >
> > 	https://github.com/nox/otp/compare/erlang:maint...export_all-behaviour
> > 	https://github.com/nox/otp/compare/erlang:maint...export_all-behaviour.patch
> >
> > Regards,
> >
> Hello Anthony,
> I've fetched your patch, applied the correct bootstrap file and assigned
> it to be reviewed by responsible developers.
> Thanks,
> 
> --
> 
> BR Fredrik Gustafsson
> Erlang OTP Team
> 
> _______________________________________________
> erlang-bugs mailing list
> [email protected]
> http://erlang.org/mailman/listinfo/erlang-bugs
> 
_______________________________________________
erlang-bugs mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-bugs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.