Re: crypto: Add IGE mode for AES
Yura Beznos <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <CAE_U+ARK4Bi5_CyEXfHHPAPpFdzqg0TsWGBPHW4W5U12fpiHiQ@mail.gmail.com> |
Hello! The patch isn't graduated ? (IGE mode for AES) On Tue, Aug 13, 2013 at 11:31 PM, Yura Beznos <[email protected]>wrote: > > On Tue, Aug 13, 2013 at 4:43 PM, Sverker Eriksson < > [email protected]> wrote: > >> Fredrik wrote: >> >>> On 08/01/2013 07:40 AM, Yura Beznos wrote: >>> >>>> Hello, >>>> >>>> I'd like to submit this patch to add two new functions to the crypt >>>> library. >>>> >>>> Repo branch: https://github.com/Zhiz0id/otp/tree/aes_ige_crypt >>>> Compare: >>>> https://github.com/Zhiz0id/otp/compare/erlang:master...aes_ige_crypt >>>> >>>> Why this new feature? >>>> >>>> It allows to use OpenSSL aes_ige_encrypt function. >>>> >>>> Risks / uncertain artifacts >>>> >>>> None. >>>> >>>> How did you solve it? >>>> >>>> Added two functions: aes_ige_256_decrypt, aes_ige_256_encrypt . >>>> >>>> >>>> Thanks. >>>> >>>> >>>> -- >>>> Yura >>>> >>>> >>>> >>>> _______________________________________________ >>>> erlang-patches mailing list >>>> [email protected] >>>> http://erlang.org/mailman/listinfo/erlang-patches >>>> >>> Hello Yura, >>> I've assigned this patch to be reviewed by responsible, you will get >>> feedback as soon as this is done. >>> Thanks, >>> >> >> Looks good, Yura. Two objections though: >> >> 1. Do not export the aes_ige_256_encrypt/decrypt functions. Users should >> only use block_encrypt/4 and block_decrypt/4. >> >> 2. Documentation updates is missing (of block_encrypt/4 and >> block_decrypt/4). >> >> >> /Sverker, Erlang/OTP >> >> > > Compare url: > https://github.com/Zhiz0id/otp/compare/erlang:master...aes_ige_crypt > _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches