Re: [erlang-bugs] sys_core_fold forgets about aliases when marking bit string variables for context reusing
Björn Gustavsson <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches,gmane.comp.lang.erlang.bugs |
|---|---|
| Message-ID | <CA+yh78Q7eQuHP6yJtGx8kEeenmP-1M2--jwD7i-E4+1Wi0TAdQ@mail.gmail.com> |
On Fri, Dec 6, 2013 at 11:07 AM, Anthony Ramine <[email protected]> wrote: > That’s for the original bug, but the fix I did is way more pervasive, > don’t you think? > > Any additional suites I should patch for that reason? > > core_fold_SUITE.erl I have not looked closely at the patch yet, but I have a few questions: The variable GSub is named that way because it was only used for the guard. Shouldn't it be renamed now that it is used both for the guard and body? Shouldn't the comment be updated? -- Björn Gustavsson, Erlang/OTP, Ericsson AB _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches