Re: EEP37: Funs with names
Anthony Ramine <[email protected]>
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <[email protected]> |
Hello, Thanks for the review, will take care of it. Commented inline. -- Anthony Ramine Le 11 déc. 2013 à 16:02, Björn Gustavsson <[email protected]> a écrit : > On Thu, Dec 5, 2013 at 1:16 PM, Anthony Ramine <[email protected]> wrote: > Done. > > Please don’t ask me this again, the two bootstrap commits in the middle of the branch are a pain to rebase :p > > > OK. Will try to avoid that. > > We also had some interesting merge conflicts trying > to include this branch in our daily builds (conflicts with another > language exentsion), so it has taken me longer than I > hoped to see the test results. Was the extension maps? I imagine the mess merging all of that, heh. > Anyway, it turns out that ordinary funs no longer > work in the debugger. It is probably my fault. The > evaluation code depends on order of the items in the > fun environment, which is not guaranteed to stay > unchanged. So I have rewritten the code in a safer > way. It can be found here: > > git fetch [email protected]:bjorng/otp.git nox/eep37 > > Have a look at it and see if you agree with my > solution. Your solution is correct. But shouldn’t that be done in erl_eval too? > Then there is one more thing. The test case > erl_lint_SUITE:unused_vars_warn_fun/1 fails. > It think that is the last thing that will need to be > fixed before merging the branch. There is probably a bug in my erl_lint modifications, guess who won a rebase… > /Bjorn > > -- > Björn Gustavsson, Erlang/OTP, Ericsson AB _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches