Re: R17.0-rc1 patch for gzio.c compile breakage.

Björn Gustavsson <[email protected]> Tue, 4 Feb 2014 15:27:42 +0100
Newsgroups gmane.comp.lang.erlang.patches
Message-ID <CA+yh78QZBSogGG06GCSijM7PWKFhS6wRyPSX5CNvB9wzaSeCmg@mail.gmail.com>
On Mon, Feb 3, 2014 at 6:35 PM, Daniel Goertzen
<[email protected]> wrote:
> A dependency on zlib.h was recently removed (commit 8a147a7365).  This also
> removes the definition of the macro "OF" which is required by gzio.c.  Now
> "OF" is evidently defined by other headers on some systems, but on at least
> Gentoo Linux this is not the case.

The OF() macro is defined in zconf.h, which is included by zlib.h, so
I don't understand why the build should break on Gentoo Linux.

But since the use of OF() is completely unnecessary and is an
unnecessary dependency I have written a commit message for your
patch and included it in our daily builds.

git fetch [email protected]:bjorng/otp.git bjorn/erts/zlib-1.2.8/OTP-11669

/Bjorn

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB
_______________________________________________
erlang-patches mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-patches