Re: Fix DTrace build on Illumos
Lukas Larsson <[email protected]> Tue, 4 Feb 2014 18:24:37 +0100
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <[email protected]> |
Hello Ryan, I just noticed that you removed the "2> /dev/null" for the 2STEP_TEST in erts/configure.in. Was there a reason for doing that? As it is now when the test fails on osx in prints the output of the dtrace command to the shell which is not really what you want. Lukas On 15/01/14 23:32, Ryan Zezeski wrote: > Any news? Would be nice if R17 worked with DTrace on latest Illumos > kernel. > > > On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <[email protected] > <mailto:[email protected]>> wrote: > > Thank you for your contribution ! > > patch has been assigned to be reviewed > > > > On 2013-12-07 22:00, Ryan Zezeski wrote: >> https://github.com/erlang/otp/pull/156 >> >> This patch fixes the configure and Makefile scripts to work with >> newer DTrace. This applies to all Illumos derivatives including >> OpenIndiana, SmartOS and OmnioOS. I've copied the commit message >> here verbatim. >> >> --- SNIP --- >> >> Fix DTrace build on Illumos >> >> DTrace was recently patched in Illumos to fail to create an >> object >> file if no probes are found. >> >> * https://www.illumos.org/issues/4248 >> * >> https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59 >> >> This patch fixes two issues: >> >> * Modify the configure script to pass an object file to >> `dtrace -G` >> that actually invokes a probe. >> >> * Remove creation of `dtrace_user.o` from the dyntrace >> Makefile. In a >> previous commit [1] Scott Fritchie relocated all the user >> probes >> into the VM proper due to difficulties with DTrace probes >> in shared >> libraries. The `dtrace_user.d` file is now empty and >> generates a >> header file with nothing in it. There is no longer any >> reason to >> generate `dtrace_user.o` because all the probes are in the >> VM. Thus >> all the steps for building `dtrace_user.o` have been removed. >> >> [1]: >> https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99 >> >> --- END SNIP --- >> >> -Z >> >> >> _______________________________________________ >> erlang-patches mailing list >> [email protected] <mailto:[email protected]> >> http://erlang.org/mailman/listinfo/erlang-patches > > -- > /Henrik Nord Erlang/OTP > > > > > _______________________________________________ > erlang-patches mailing list > [email protected] > http://erlang.org/mailman/listinfo/erlang-patches _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches