Re: sasl: Fix function_clause in systools_make:format_error/1
Henrik Nord <[email protected]> Mon, 24 Mar 2014 15:34:50 +0100
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <[email protected]> |
Hi As I mentioned in the previous email, I created a pull request from your branch. Now that you are adding to it, It would be nice if you could create your own PR from your branch so that you can keep that up to date. Also, keep in mind the guidelines for writing good commit messages. https://github.com/erlang/otp/wiki/Writing-good-commit-messages Thank you for your contributions! On 2014-03-24 15:30, Jean-Sébastien Pédron wrote: > On 20.03.2014 11:15, Siri Hansen wrote: >> It would be really good if you could add a test case for it also, so >> it does not happen again. > I pushed a second commit to the same branch to add a test case. > > Here's the branch information again, just in case: > > git fetch git://github.com/dumbbell/otp.git > function_clause-in-systools_make-format_error > > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error > https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch > > Thank you! > > > > _______________________________________________ > erlang-patches mailing list > [email protected] > http://erlang.org/mailman/listinfo/erlang-patches -- /Henrik Nord Erlang/OTP _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches