Re: sasl: Fix function_clause in systools_make:format_error/1
Siri Hansen <[email protected]> Mon, 24 Mar 2014 17:13:54 +0100
| Newsgroups | gmane.comp.lang.erlang.patches |
|---|---|
| Message-ID | <CAGqERUHGe7miSE0_gEzXWDD5iOm1pGza4_QwpMmE+t9NSCZnRA@mail.gmail.com> |
It's ok to use the current pull request. And yes, please squash the commits into one and fix the commit message (please read this page again, it's just been updated: https://github.com/erlang/otp/wiki/Writing-good-commit-messages) Thanks /siri 2014-03-24 16:14 GMT+01:00 Jean-Sébastien Pédron < [email protected]>: > On 24.03.2014 15:34, Henrik Nord wrote: > > Now that you are adding to it, It would be nice if you could create your > > own PR from your branch so that you can keep that up to date. > > Hi! > > That's what I tried before replying but GitHub reuses the current pull > request. > > I'm not used to work with pull requests. What would you suggest? Do you > want me to amend the commits (maybe squash them into one) and improve > the commit message at the same time? > > -- > Jean-Sébastien Pédron > > _______________________________________________ erlang-patches mailing list [email protected] http://erlang.org/mailman/listinfo/erlang-patches