Re: [jinterface] fix regression of 4390e43558 writing small compressed values

--===============5079784973189535480==
Content-Type: multipart/alternative; boundary=001a11c3aa1cfc55b705242102c9

--001a11c3aa1cfc55b705242102c9
Content-Type: text/plain; charset=UTF-8

Hi Nico,

Yes, indeed, that slipped through. I'm sorry if it caused you any
inconvenience.

Please open a pull request with that change.

regards,
Vlad


On Mon, Nov 9, 2015 at 8:50 PM, Nico Kruber <[email protected]> wrote:

> Hi,
> we came across a regression in the JInterface code which slipped in for
> Erlang
> 17.5 iirc. It prevents the Java code to compress e.g. the string "{}" the
> way,
> erlang:term_to_binary("{}", [compressed]) does. The patch is rather simple
> and
> reverts the changes of 4390e43558 to the OtpOutputStream class and adds
> appropriate test cases to prevent further breakages.
>
>
> https://github.com/erlang/otp/compare/maint...NicoK:maint
> https://github.com/erlang/otp/compare/maint...NicoK:maint.patch
>
>
>
>
> Nico
> _______________________________________________
> erlang-patches mailing list
> [email protected]
> http://erlang.org/mailman/listinfo/erlang-patches
>
>

--001a11c3aa1cfc55b705242102c9
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Nico,<div><br></div><div>Yes, indeed, that slipped thro=
ugh. I&#39;m sorry if it caused you any inconvenience.</div><div><br></div>=
<div>Please open a pull request with that change.</div><div><br></div><div>=
regards,</div><div>Vlad</div><div><br></div></div><div class=3D"gmail_extra=
"><br><div class=3D"gmail_quote">On Mon, Nov 9, 2015 at 8:50 PM, Nico Krube=
r <span dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"=
_blank">[email protected]</a>&gt;</span> wrote:<br><blockquote class=3D=
"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
-left:1ex">Hi,<br>
we came across a regression in the JInterface code which slipped in for Erl=
ang<br>
17.5 iirc. It prevents the Java code to compress e.g. the string &quot;{}&q=
uot; the way,<br>
erlang:term_to_binary(&quot;{}&quot;, [compressed]) does. The patch is rath=
er simple and<br>
reverts the changes of 4390e43558 to the OtpOutputStream class and adds<br>
appropriate test cases to prevent further breakages.<br>
<br>
<br>
<a href=3D"https://github.com/erlang/otp/compare/maint...NicoK:maint" rel=
=3D"noreferrer" target=3D"_blank">https://github.com/erlang/otp/compare/mai=
nt...NicoK:maint</a><br>
<a href=3D"https://github.com/erlang/otp/compare/maint...NicoK:maint.patch"=
 rel=3D"noreferrer" target=3D"_blank">https://github.com/erlang/otp/compare=
/maint...NicoK:maint.patch</a><br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
<br>
<br>
Nico</font></span><br>_______________________________________________<br>
erlang-patches mailing list<br>
<a href=3D"mailto:[email protected]">[email protected]</a><=
br>
<a href=3D"http://erlang.org/mailman/listinfo/erlang-patches" rel=3D"norefe=
rrer" target=3D"_blank">http://erlang.org/mailman/listinfo/erlang-patches</=
a><br>
<br></blockquote></div><br></div>

--001a11c3aa1cfc55b705242102c9--

--===============5079784973189535480==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
erlang-patches mailing list
[email protected]
http://erlang.org/mailman/listinfo/erlang-patches

--===============5079784973189535480==--