Re: Ternary operator formatting

MG <mgbiz-yvYIh6MZAuFWk0Htik3J/[email protected]> Mon, 27 Jul 2026 19:03:00 +0200
Newsgroups	gmane.comp.lang.groovy.devel
Message-ID	<[email protected]>
This is a multi-part message in MIME format.
--------------ZYKEpfn0eD6C6YQZhWRxDFya
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Gianluca,

I might misuderstand what you propose here, but for me the whole idea 
behind cond ? trueBranch : falseBranch is that it is a one-liner.
Otherwise it is better suited for if-else-...

Having said that, I can see that this way of formatting might make 
sense, if trueBranch and falseBranch are long(ish) String/GString|s 
(which we in our code do not have) - but as a general formatting rule, I 
would be against this.

Cheers,
mg


Am 27.07.2026 um 14:38 schrieb Gianluca Sartori:
> Hi people,
>
> I've proposed the following PR to the Grails project in a rush, but I 
> guess its proper place is the Groovy project.
>
> https://github.com/apache/grails-core/pull/16055
>
> We usually format ternary operators like this for readability:
>
> String message = condition
>         ? "Value when true"
>         : "Value when false"
>
> Would you accept such PR on the groovy-developer skill?
>
> Cheers,
> Gianluca
>
> Gianluca Sartori
> --
> https://dueuno.com

--------------ZYKEpfn0eD6C6YQZhWRxDFya
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    Hi Gianluca,<br>
    <br>
    I might misuderstand what you propose here, but for me the whole
    idea behind cond ? trueBranch : falseBranch is that it is a
    one-liner.<br>
    Otherwise it is better suited for if-else-...<br>
    <br>
    Having said that, I can see that this way of formatting might make
    sense, if trueBranch and falseBranch are long(ish) String/GString|s
    (which we in our code do not have) - but as a general formatting
    rule, I would be against this.<br>
    <br>
    Cheers,<br>
    mg<br>
    <br>
    <br>
    <div class="moz-cite-prefix">Am 27.07.2026 um 14:38 schrieb Gianluca
      Sartori:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAEJ7v=kKE6H1ebkamuYWXLi-A2o0Rk42JYOXx5cO7esNUjg1qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div>Hi people,<br clear="all">
        </div>
        <div><br>
        </div>
        <div>I've proposed the following PR to the Grails project in a
          rush, but I guess its proper place is the Groovy project.</div>
        <div><br>
        </div>
        <div><a href="https://github.com/apache/grails-core/pull/16055"
            moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/apache/grails-core/pull/16055</a></div>
        <div><br>
        </div>
        <div>We usually<span style="background-color:transparent"> format
            ternary operators like this for readability:</span></div>
        <div><br>
        </div>
        <div>String message = condition<br>
                  ? "Value when true"<br>
                  : "Value when false"</div>
        <div><br>
        </div>
        <div>Would you accept such PR on the groovy-developer skill?</div>
        <div><br>
        </div>
        <div>Cheers,</div>
        <div>Gianluca</div>
        <div><br>
        </div>
        <div>
          <div dir="ltr" class="gmail_signature"
            data-smartmail="gmail_signature">
            <div dir="ltr">Gianluca Sartori
              <div>--</div>
              <div><a href="https://dueuno.com" target="_blank"
                  moz-do-not-send="true" class="moz-txt-link-freetext">https://dueuno.com</a></div>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>

--------------ZYKEpfn0eD6C6YQZhWRxDFya--