Re: Ternary operator formatting
Gianluca Sartori <[email protected]> Tue, 28 Jul 2026 10:00:37 +0200
| Newsgroups | gmane.comp.lang.groovy.devel |
|---|---|
| Message-ID | <CAEJ7v=kgZRKAgR1ojojAeF9tYWk0JKbVa3gHw5RZY3+j02FapA@mail.gmail.com> |
--0000000000009fa7b20657a73ce7 Content-Type: text/plain; charset="UTF-8" That's the idea, to use the multiline style only when there are longer expressions like strings, method calls, etc. Anyway I just realized there is no `groovy-developer` skill in the groovy project, maybe Grails is the right place to work on it? Gianluca Sartori -- https://dueuno.com On Mon, 27 Jul 2026 at 19:03, MG <mgbiz-yvYIh6MZAuFWk0Htik3J/[email protected]> wrote: > Hi Gianluca, > > I might misuderstand what you propose here, but for me the whole idea > behind cond ? trueBranch : falseBranch is that it is a one-liner. > Otherwise it is better suited for if-else-... > > Having said that, I can see that this way of formatting might make sense, > if trueBranch and falseBranch are long(ish) String/GString|s (which we in > our code do not have) - but as a general formatting rule, I would be > against this. > > Cheers, > mg > > > Am 27.07.2026 um 14:38 schrieb Gianluca Sartori: > > Hi people, > > I've proposed the following PR to the Grails project in a rush, but I > guess its proper place is the Groovy project. > > https://github.com/apache/grails-core/pull/16055 > > We usually format ternary operators like this for readability: > > String message = condition > ? "Value when true" > : "Value when false" > > Would you accept such PR on the groovy-developer skill? > > Cheers, > Gianluca > > Gianluca Sartori > -- > https://dueuno.com > > > --0000000000009fa7b20657a73ce7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>That's the idea, to use the multiline style only = when there are longer expressions like strings, method calls, etc.</div><di= v><br></div><div>Anyway I just realized there is no `groovy-developer` skil= l in the groovy project, maybe Grails is the right place to work on it?</di= v><div><br></div><div><br></div><div><div dir=3D"ltr" class=3D"gmail_signat= ure" data-smartmail=3D"gmail_signature"><div dir=3D"ltr">Gianluca Sartori<d= iv>--</div><div><a href=3D"https://dueuno.com" target=3D"_blank">https://du= euno.com</a></div></div></div></div><br></div><br><div class=3D"gmail_quote= gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 27 Ju= l 2026 at 19:03, MG <<a href=3D"mailto:mgbiz-yvYIh6MZAuFWk0Htik3J/[email protected]">mgbiz@arscrea= t.com</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"ma= rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:= 1ex"><u></u> =20 =20 =20 <div> Hi Gianluca,<br> <br> I might misuderstand what you propose here, but for me the whole idea behind cond ? trueBranch : falseBranch is that it is a one-liner.<br> Otherwise it is better suited for if-else-...<br> <br> Having said that, I can see that this way of formatting might make sense, if trueBranch and falseBranch are long(ish) String/GString|s (which we in our code do not have) - but as a general formatting rule, I would be against this.<br> <br> Cheers,<br> mg<br> <br> <br> <div>Am 27.07.2026 um 14:38 schrieb Gianluca Sartori:<br> </div> <blockquote type=3D"cite"> =20 <div dir=3D"ltr"> <div>Hi people,<br clear=3D"all"> </div> <div><br> </div> <div>I've proposed the following PR to the Grails project in a rush, but I guess its proper=C2=A0place is the Groovy project.</d= iv> <div><br> </div> <div><a href=3D"https://github.com/apache/grails-core/pull/16055" t= arget=3D"_blank">https://github.com/apache/grails-core/pull/16055</a></div> <div><br> </div> <div>We usually<span style=3D"background-color:transparent">=C2=A0f= ormat ternary operators like this for readability:</span></div> <div><br> </div> <div>String message =3D condition<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 ? "Value when true"<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 : "Value when false"</div> <div><br> </div> <div>Would you accept such PR on the groovy-developer skill?</div> <div><br> </div> <div>Cheers,</div> <div>Gianluca</div> <div><br> </div> <div> <div dir=3D"ltr" class=3D"gmail_signature"> <div dir=3D"ltr">Gianluca Sartori <div>--</div> <div><a href=3D"https://dueuno.com" target=3D"_blank">https:/= /dueuno.com</a></div> </div> </div> </div> </div> </blockquote> <br> </div> </blockquote></div> --0000000000009fa7b20657a73ce7--