Re: [commit: ghc] master: add a missing entryCode (a910970)

Ian Lynagh <[email protected]> Thu, 20 Sep 2012 17:07:46 +0100

Newsgroups	gmane.comp.lang.haskell.cvs.ghc
Message-ID	<[email protected]>

On Thu, Sep 20, 2012 at 08:35:36AM -0700, Simon Marlow wrote:
> 
> diff --git a/compiler/cmm/CmmLayoutStack.hs b/compiler/cmm/CmmLayoutStack.hs
> index 5505b92..b4ca273 100644
> --- a/compiler/cmm/CmmLayoutStack.hs
> +++ b/compiler/cmm/CmmLayoutStack.hs
> @@ -5,6 +5,7 @@ module CmmLayoutStack (
>  
>  import StgCmmUtils      ( callerSaveVolatileRegs ) -- XXX
>  import StgCmmForeign    ( saveThreadState, loadThreadState ) -- XXX
> +import StgCmmLayout     ( entryCode ) -- XXX

What do these XXXs mean? I guess that an abstraction is being broken by
using them? Would it make sense to add a comment saying why, and what
the solution might be?


Thanks
Ian