Re: [commit: testsuite] master: Failing (by timeout) tests for #367. (fbd0aaa)

On 24/09/2012 22:39, Edward Z. Yang wrote:

> --- a/tests/concurrent/should_run/all.T
> +++ b/tests/concurrent/should_run/all.T
> @@ -21,6 +21,10 @@ test('conc071', omit_ways(['threaded2']), compile_and_run, [''])
>   test('conc072', only_ways(['threaded2']), compile_and_run, [''])
>   test('conc073', normal, compile_and_run, [''])
>
> +# vector code must get inlined to become non-allocating
> +test('367', composes([skip_if_fast, expect_fail]), compile_and_run, ['-O2'])
> +test('367_letnoescape', composes([skip_if_fast, expect_fail]), compile_and_run, [''])
> +
>   test('1980', normal, compile_and_run, [''])
>   test('2910', normal, compile_and_run, [''])
>   test('2910a', normal, compile_and_run, [''])

A couple of tips: you need a reqlib('vector') there, and instead of 
expect_fail it would be better to use expect_broken(367).

These tests will timeout after 5 minutes, right?  I think we ought to 
reduce the timeout otherwise we'll be adding another 60+ mins to the 
nightly builds (5 minutes per way, 2 tests).  That will mean modifying 
the testsuite driver so that the timeout threshold can be changed on a 
per-test basis.

In my validate build here I get 7 unexpected passes for 367.  Perhaps 
that is because the vector library is only compiled with `-O`, not `-O2`?

Cheers,
	Simon