Re: [commit: ghc] master: Add a new traceMarker# primop for use in profiling output (a609027)

Did you forget to add a:
void dtraceUserMarkerWrapper(Capability *cap, char *msg)

to Trace.c? It's only defined in Trace.h

I'm getting this error:

  HC [stage 1] ghc/stage2/build/tmp/ghc-stage2
Undefined symbols:
  "_dtraceUserMarkerWrapper", referenced from:
      _stg_traceMarkerzh in libHSrts_thr.a(PrimOps.thr_o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[1]: *** [ghc/stage2/build/tmp/ghc-stage2] Error 1
make: *** [all] Error 2

On Oct 15, 2012, at 10:45 PM, Duncan Coutts wrote:

> Repository : ssh://darcs.haskell.org//srv/darcs/ghc
> 
> On branch  : master
> 
> http://hackage.haskell.org/trac/ghc/changeset/a609027da31c7c9103d8b9741ba3fc6807b7b7b9
> 
>> ---------------------------------------------------------------
> 
> commit a609027da31c7c9103d8b9741ba3fc6807b7b7b9
> Author: Duncan Coutts <[email protected]>
> Date:   Mon Oct 15 00:52:32 2012 +0100
> 
>    Add a new traceMarker# primop for use in profiling output
> 
>    In time-based profiling visualisations (e.g. heap profiles and ThreadScope)
>    it would be useful to be able to mark particular points in the execution and
>    have those points in time marked in the visualisation.
> 
>    The traceMarker# primop currently emits an event into the eventlog. In
>    principle it could be extended to do something in the heap profiling too.
> 
> compiler/prelude/primops.txt.pp |   11 +++++++++++
> includes/rts/EventLogFormat.h   |    6 +++---
> includes/stg/MiscClosures.h     |    1 +
> rts/Linker.c                    |    1 +
> rts/PrimOps.cmm                 |   25 +++++++++++++++++++++++++
> rts/RtsProbes.d                 |    1 +
> rts/Trace.c                     |   22 ++++++++++++++++++++++
> rts/Trace.h                     |   10 ++++++++++
> rts/eventlog/EventLog.c         |   23 +++++++++++++++++++++++
> rts/eventlog/EventLog.h         |    2 ++
> 10 files changed, 99 insertions(+), 3 deletions(-)
> 
> 
> Diff suppressed because of size. To see it, use:
> 
>    git show a609027da31c7c9103d8b9741ba3fc6807b7b7b9
> 
> _______________________________________________
> Cvs-ghc mailing list
> [email protected]
> http://www.haskell.org/mailman/listinfo/cvs-ghc