Re: [commit: ghc] master: Fix the OFFSET macro (53e9916)

Hi Gaby,

On Thu, Nov 15, 2012 at 11:26:04AM -0600, Gabriel Dos Reis wrote:
> On Tue, Nov 13, 2012 at 1:41 PM, Ian Lynagh <[email protected]> wrote:
> >
> >     When offsetof is defined, we use that. This avoids "variably
> >     modified at file scope" warnings/errors with recent gccs.
> 
> Is there at all any C compiler used to build GHC that does not
> define offsetof?  It is a standard C macro defined in <stddef.h>
> that even freestanding C compilers have to provide.

I think you're probably right. I was being conservative, so as to be
sure not to break anything, but I've made it unconditionally use
offsetof now. I'm sure that we'll hear soon enough if that causes any
problems.


Thanks
Ian