Re: [commit: ghc] master: Stop attempting to "trim" data types in interface files (9a20e54)

On 06/12/12 16:03, Simon Peyton Jones wrote:
> Repository : ssh://darcs.haskell.org//srv/darcs/ghc
>
> On branch  : master
>
> http://hackage.haskell.org/trac/ghc/changeset/9a20e540754fc2af74c2e7392f2786a81d8d5f11
>
>> ---------------------------------------------------------------
>
> commit 9a20e540754fc2af74c2e7392f2786a81d8d5f11
> Author: Simon Peyton Jones <[email protected]>
> Date:   Thu Dec 6 16:03:16 2012 +0000
>
>      Stop attempting to "trim" data types in interface files
>
>      Without -O, we previously tried to make interface files smaller
>      by not including the data constructors of data types.  But
>      there are a lot of exceptions, notably when Template Haskell is
>      involved or, more recently, DataKinds.
>
>      However Trac #7445 shows that even without TemplateHaskell, using
>      the Data class and invoking Language.Haskell.TH.Quote.dataToExpQ
>      is enough to require us to expose the data constructors.
>
>      So I've given up on this "optimisation" -- it's probably not
>      important anyway.  Now I'm simply not attempting to trim off
>      the data constructors.  The gain in simplicity is worth the
>      modest cost in interface file growth, which is limited to the
>      bits reqd to describe those data constructors.

That's a shame - it wasn't so much a reduction in interface file size we 
gained by doing this, but less recompilation.  Oh well...

Cheers,
	Simon