Re: ettiquette for changing an MR under review?

--===============2940445559647103104==
Content-Type: multipart/alternative; boundary="0000000000003b5ecb05d78999c8"

--0000000000003b5ecb05d78999c8
Content-Type: text/plain; charset="UTF-8"

I'd just make the changes, and push as a new patch.  Once everything has
settled down, you can compress all the patches into one and force push.

Simon

On Tue, 8 Feb 2022 at 20:44, Norman Ramsey <[email protected]> wrote:

> I have an MR currently under review.  Review has already identified a
> change I need to make, and I have made it in my local repository.
> Do I push the change now, or do I wait for a more complete review?
> And if I push it now, do I force-push or do I push the changes as a
> separate commit?
>
>
> Norman
> _______________________________________________
> ghc-devs mailing list
> [email protected]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>

--0000000000003b5ecb05d78999c8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:tahoma,s=
ans-serif">I&#39;d just make the changes, and push as a new patch.=C2=A0 On=
ce everything has settled down, you can compress all the patches into one a=
nd force push.</div><div class=3D"gmail_default" style=3D"font-family:tahom=
a,sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family:t=
ahoma,sans-serif">Simon<br></div></div><br><div class=3D"gmail_quote"><div =
dir=3D"ltr" class=3D"gmail_attr">On Tue, 8 Feb 2022 at 20:44, Norman Ramsey=
 &lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt; wrote:<br><=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex">I have an MR current=
ly under review.=C2=A0 Review has already identified a<br>
change I need to make, and I have made it in my local repository. <br>
Do I push the change now, or do I wait for a more complete review?<br>
And if I push it now, do I force-push or do I push the changes as a<br>
separate commit?<br>
<br>
<br>
Norman<br>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href=3D"mailto:[email protected]" target=3D"_blank">ghc-devs@haskell.=
org</a><br>
<a href=3D"http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel=
=3D"noreferrer" target=3D"_blank">http://mail.haskell.org/cgi-bin/mailman/l=
istinfo/ghc-devs</a><br>
</blockquote></div>

--0000000000003b5ecb05d78999c8--

--===============2940445559647103104==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZ2hjLWRldnMg
bWFpbGluZyBsaXN0CmdoYy1kZXZzQGhhc2tlbGwub3JnCmh0dHA6Ly9tYWlsLmhhc2tlbGwub3Jn
L2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9naGMtZGV2cwo=

--===============2940445559647103104==--