Re: #16265: API Annotations: parens anns discarded for `(*)` operator

"GHC" <[email protected]> Mon, 04 Mar 2019 18:51:01 -0000
Newsgroups gmane.comp.lang.haskell.glasgow.bugs
Message-ID <[email protected]>
#16265: API Annotations: parens anns discarded for `(*)` operator
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  merge
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Compiler          |              Version:  8.6.3
  (Parser)                           |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Marge Bot <ben+marge-bot@…>):

 In [changeset:"5e9888bd9c22a1315a703f638591b50e657317c4/ghc" 5e9888b/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5e9888bd9c22a1315a703f638591b50e657317c4"
 API Annotations: parens anns discarded for `(*)` operator

 The patch from https://phabricator.haskell.org/D4865 introduces

     go _ (HsParTy _ (dL->L l (HsStarTy _ isUni))) acc ann fix
       = do { warnStarBndr l
            ; let name = mkOccName tcClsName (if isUni then "★" else "*")
            ; return (cL l (Unqual name), acc, fix, ann) }

 which discards the parens annotations belonging to the HsParTy.

 Updates haddock submodule

 Closes #16265
 }}}

-- 
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16265#comment:4>