PyBytes for Jython 3 waiting for review and other Jython 3 dev related questions
Antti Haapala <[email protected]>
| Newsgroups | gmane.comp.lang.jython.devel |
|---|---|
| Message-ID | <CA+HSgbLvJ7n_UK=4tqM1ybpkhu-z6V9PFVh3c45xU+7iBc7TPw@mail.gmail.com> |
Hi all, I'd like to contribute substantially to the Jython 3 development. I am far from a n00b with Java or Python, but I really didn't know anything about the internals of Jython before ~2 weeks ago, thus I'd guess not even of much use with Jython 2.7 development even if I wanted. But Jython 3 changes would be something where I could be quite useful - Alex Grönholm already merged some of my PRs to Jython 3 sandbox. ---- I have made a pull request that introduces PyBytes to Jython 3 - basically what I did was to take the PyByteArray and removed the mutating methods, changed the __repr__, etc. It was suggested that Jeff Allen should review my PyBytes PR at https://github.com/jython/jython3/pull/5/files - so it'd be nice if Jeff you could review it. That commit also makes the compiler to produce bytes literals with b'foo'; the bytes literals would be stored as "latin-1" string constants in .class files. The code "works for me (tm)" in the interactive interpreter. ---- Next, if the PyBytes were be accepted, I was thinking I'd want to try merging PyInteger with PyLong; and PyString with PyUnicode if no one else has it coming yet. However, naming things is still hard. What do you all think the Python 3 str and int should be called on the Java side? CPython 3 still calls them PyUnicode* and PyLong*, which makes sense, since their C-API is consistent with these Python 2 types; and all usages of PyString* and PyInt* should be reviewed for changes when porting extensions to Python 3. ---- Also, I've listed some to-do items in the Github issue tracker; how do you feel about using the Github issue tracker at least for this in the early phase of Jython 3 experimentation? Or should these too be in Roundup? Any thoughts? -- Antti Haapala ------------------------------------------------------------------------------ _______________________________________________ Jython-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jython-dev