Re: Failing tests on GitHub
Jeff Allen <[email protected]>
| Newsgroups | gmane.comp.lang.jython.devel |
|---|---|
| Message-ID | <[email protected]> |
Yes, it was misleading to put test_sort in the same list. It fails for Java 8, everywhere AFAIK (http://bugs.jython.org/issue2399), best dealt with in regrtest somehow I suppose. With test_socket test_sort test_ssl we could exclude them from the custom ant regrtest-*, but it would be nicer if the environment allowed them to run. (Not testing SSL seems a bit shoddy.) Jeff Allen On 13/03/2017 20:07, Adam Burke wrote: > If test_socket and test_ssl fail due to environmental reasons - eg can't reliably obtain a non-clashing socket on the build server - it's probably worth having a mechanism to distinguish and disable them in that environment. > > Test_sort seems like it should pass everywhere though? > > Adam > >> 在 2017年3月13日，下午5:59，Jeff Allen <[email protected]> 写道： >> >> A while ago our GitHub repo >> https://github.com/jythontools/jython/commits/master sprouted continuous >> integration tests, thanks (I think) to Darjus. However, these tests >> always fail. >> >> This seems to me to remove their primary value, which is as a tripwire >> to tell us when something has broken, or when a PR would break it. >> That's particularly valuable where tests run on a different platform >> from the developer's regression test. >> >> The tests failing at GitHub (over the various tools and test >> conditions), that don't fail on the (= my Windows) desktop, are: >> >> test_socket test_sort test_ssl >> >> I'm tweaking the expected failures in regrtest to get it to run cleanly >> again under ant on the desktop, as we encourage users to run that. But >> perhaps the target should be to have it run cleanly at GitHub too, >> adding things that don't to the "list of shame". >> >> Is it sensible to add as expected failures, those things that routinely >> fail in the GitHub tests? Or do they fail for a reason we could >> immediately fix by configuration there? >> >> Jeff >> >> -- >> Jeff Allen >> >> >> ------------------------------------------------------------------------------ >> Announcing the Oxford Dictionaries API! The API offers world-renowned >> dictionary content that is easy and intuitive to access. Sign up for an >> account today to start using our lexical data to power your apps and >> projects. Get started today and enter our developer competition. >> http://sdm.link/oxford >> _______________________________________________ >> Jython-dev mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/jython-dev ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Jython-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jython-dev