Re: [MLton] Patch for modern x86_64-pc-cygwin and x86_64-w64-mingw32

The patches look fine.  Darwin certainly required leading underscores
in assembly labels; "(Darwin,  _) => false" would better preserve the
existing behavior.

Do you want to submit a pull request through GitHub?

On Mon, Apr 17, 2017 at 12:08 PM, Kent Wilson <[email protected]> wrote:
> Hi,
>
> I've been working with these platforms for a while and have been self
> patching the source code to get the runtimes, and mlton-compile executable
> to work. I have attached a patch that gets the mentioned platforms working.
>
> There are two problems that I have identified:
>
> 1) GCC compilers newer than 4.8 create the same symbol names as *NIX
> platforms (at least for the x86_64 code generators). I have added
> Architecture checks to the Control.labelsHaveExtra_ call in
> mlton/main/main.fun that correct the compiler on those platforms. I do not
> know if the Darwin platform has changed, so it is left as is.
>
> 2) The recent git commits that added SIGALT_STACK checks have broken
> compiling the runtime for the mentioned platforms. I have added the
> necessary defines to the platform headers.
>
> As a side note, I have a native amd64 codegen compiler working on OpenBSD
> amd64 for both 5.9 and 6.0.
>
> Thank you,
>
> --
> Kent Wilson
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> MLton-devel mailing list
> [email protected]; [email protected]
> https://lists.sourceforge.net/lists/listinfo/mlton-devel
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot