Re: [PATCH] Missing include file for latest libgnomeui

OBATA Akio pointed me to this mailing list and the messages
http://www.math.nagoya-u.ac.jp/~garrigue/soft/olabl/lablgtk-list/496.txt
and
http://www.math.nagoya-u.ac.jp/~garrigue/soft/olabl/lablgtk-list/500.txt

The error that I get without the patch is as shown in the forwarded mail
below (which pertains to the latest NetBSD).

With the patch, compilation completes, so it would be nice to include
it officially.

I suppose that it might be necessary to do a check in configure if the
header file is present, if older versions of libgnomeui don't have it
(I don't know, I don't track those things).

----- Forwarded message from Rhialto <[email protected]> -----

Date: Mon, 11 May 2009 21:43:33 +0200
From: Rhialto <[email protected]>
Subject: x11/lablgtk fails to compile 2009Q1, i386/5.0
To: [email protected]

The build ends like this:

+ gcc -fno-defer-pop -Wall -D_FILE_OFFSET_BITS=64 -D_REENTRANT -fPIC -c -O2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/freetype2 -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -L/usr/X11R7/lib -Wl,-R/usr/X11R7/lib -DG_DISABLE_ASSERT -DG_DISABLE_CAST_CHECKS -D_REENTRANT -DORBIT2=1 -pthread -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/lib/gtk-2.0/include -I/usr/pkg/include/atk-1.0 -I/usr/pkg/include/cairo -I/usr/pkg/include/pango-1.0 -I/usr/X11R7/include -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/X11R7/include/pixman-1 -I/usr/X11R7/include/freetype2 -I/usr/pkg/include -I/usr/pkg/include/libpng12 -I/usr/pkg/include/librsvg-2 -I/usr/pkg/include/libgnomecanvas-2.0 -I/usr/pkg/include/gail-1.0 -I/usr/pkg/include/libart-2.0 -I/usr/pkg/include/libgnomeui-2.0 -I/usr/pkg/include/gconf/2 -I/usr/pkg/include/gnome-keyring-1 -I/usr/pkg/include/libgnome-2.0 -I/usr/pkg/include/libbonoboui-2.0 -I/usr/pkg/include/gnome-vfs-2.0 -I/usr/pkg/lib/gnome-vfs-2.0/include -I/usr/pkg/include/orbit-2.0 -I/usr/pkg/include/dbus-1.0 -I/usr/pkg/lib/dbus-1.0/include -I/usr/pkg/include/libbonobo-2.0 -I/usr/pkg/include/bonobo-activation-2.0 -I/usr/pkg/include/libxml2 -I/usr/pkg/include/panel-2.0 -I/usr/pkg/include/gtkspell-2.0   -imacros ml_domain.h -O  -I'/usr/pkg/lib/ocaml' 'ml_panel.c'
ml_panel.c: In function 'ml_panel_applet_factory_main':
ml_panel.c:191: error: 'LIBGNOMEUI_MODULE' undeclared (first use in this function)
ml_panel.c:191: error: (Each undeclared identifier is reported only once
ml_panel.c:191: error: for each function it appears in.)
gmake[1]: *** [ml_panel.o] Error 2
gmake[1]: Leaving directory `/pkg_comp/obj/pkgsrc/x11/lablgtk/default/lablgtk-2.12.0/src'
gmake: *** [world] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/x11/lablgtk
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/x11/lablgtk
...

----- End forwarded message -----

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert    -- You author it, and I'll reader it.
\X/ rhialto/at/xs4all.nl      -- Cetero censeo "authored" delendum esse.