Re: [code-review] Tie::Hash::RegexKeys
Torsten Hofmann <Torsten.Hofmann-3fy81iOio07EklRYOP+eR4QuADTiUCJX@public.gmane.org> Tue, 13 Jan 2004 09:53:36 +0100
| Newsgroups | gmane.comp.lang.perl.code-review-ladder |
|---|---|
| Organization | Friedrich-Alexander-Universitaet Erlangen/Nuernberg |
| Message-ID | <[email protected]> |
Peter Scott wrote:
> I've created another module intended for CPAN at
> http://www.psdt.com/Tie-Hash-RegexKeys-0.01.tar.gz pending review from
> folks here. This allows you to use regexen as hash keys and operate on
> the elements with matching keys. It's not fast when you do that, 'cos
> it scans through potentially all the keys, but it can be useful anyway.
> Looking forward to feedback.
trying
perl Build.PL
./Build
./Build test
./Build install
the testing step failed miserably as I don't have Test::Exception
installed which is not core and not listed as a required module. So
this should be included.
As a sidenote: When I change Build.PL like this to include the
aforementioned requirement:
use Module::Build;
# See perldoc Module::Build for details of how this works
Module::Build->new
( module_name => 'Tie::Hash::RegexKeys',
license => 'perl',
requires => {
'Test::Exception' => 0,
},
)->create_build_script;
Then the output I get for ./Build is:
Checking whether your kit is complete...
Looks good
ERROR: Test::Exception: Prerequisite Test::Exception isn't installed
ERRORS/WARNINGS FOUND IN PREREQUISITES. You may wish to install the
versions
of the modules indicated above before proceeding with this installation.
Is it normal that the 'Looks good' appears before the error
message/appears at all - because apparently it doesn't look good if
one of the prerquisites is missing ...
Torsten