Re: [code-review] Hello!
Jeff Yoak <[email protected]> Sun, 01 Feb 2004 17:35:20 -0800
| Newsgroups | gmane.comp.lang.perl.code-review-ladder |
|---|---|
| Message-ID | <[email protected]> |
At 03:50 AM 1/31/2004, Jean-Michel Hiver wrote: >That's quite an fun / interesting module. It would be nice to allow >expiration times under one second when Time::HiRes is installed. Yes, I thought about that. What is your suggestion about the best way to go about it? I don't like requiring Time::HiRes. It's not in the core, is it? I have it, but don't recall if I installed it personally. I could allow decimal times (actually, I don't prevent them from being entered now), and simply treat them as they are now unless I have access to Time::HiRes. Probably a warning would be appropriate if the user specifies a decimal value but doesn't have Time::HiRes available. >I did 'make test' quite a few times, and the following test failed once: > >t/1....ok 1/19# Failed test (t/1.t at line 20) ># got: undef ># expected: 'barney' >t/1....ok 17/19# Looks like you failed 1 tests of 19. Thank you very much for this. I'll check that. Cheers, Jeff