Re: [code-review] Just subscribed

Jean-Michel Hiver wrote:
> Recently I uploaded MKDoc::XML [1] on CPAN, MKDoc's unique XML
> manipulation toolkit which provides not so common XML features. I would
> like to submit this module for review.

The code is ok overall by my criteria, but since it isn't an XML parser I think 
you should change the name. An XML parser would have died the first time there:

use strict;
use MKDoc::XML::Tokenizer;
use Data::Dumper;

my @xml = (
             '<!-- comm -- ent -->',
             '<foo>',
             '<!DOCTYPE uh [ <!ELEMENT uh> la ]>'
           );

for my $x (@xml) {
     my $tokens = MKDoc::XML::Tokenizer->process_data($x);
     print Dumper $tokens;
     print "\n\n";
}

MKDoc::MKML would be fine.

-- 
Robin Berjon <[email protected]>
Research Scientist, Expway      http://expway.com/
7FC0 6F5F D864 EFB8 08CE  8E74 58E6 D5DB 4889 2488