Re: [code-review] Lingua::EN::NamedEntity

On Thursday, September 25, 2003, at 11:15  AM, Simon Cozens wrote:

> Please take a look at
> http://search.cpan.org/src/SIMON/Lingua-EN-NamedEntity-1.0/ 
> NamedEntity.pm

Nice!

It might help to add a short "=head1 FILES" section to the POD  
mentioning the use of the DB_File lookup tables, so a user has some  
idea of where to start debugging if somebody else has already installed  
the module on a shared machine and their dictionary files aren't being  
found.

More generally, if the DB_File databases are read-only, could you get  
away with putting them in the library install path instead of requiring  
each user to have an identical copy of these files in their home  
directory?

Also, the fix_scores() method seems slightly misnamed, since it doesn't  
actually fix any of the scores... Perhaps categorize_scores() or  
determine_class() would be closer to the intent?

-Simon