Re: [code-review] Tie::Hash::Sorted

On Thursday, September 25, 2003, at 11:52  AM, Joshua wrote:

> Please take a look at
> http://search.cpan.org/author/JGATCOMB/Tie-Hash-Sorted-0.10/Sorted.pm

Looks good.

Reading the documentation, I can't figure out what "the default sort 
routine" is, although I see from the source that it's "sort keys with 
cmp" -- it would be good to add a sentence to the documentation saying 
so.

> Current versions of perl (so far, 5.8.1 and below) implement scalar 
> keys %tied_hash poorly.

Also, with regard to the above line in the docs, it would be good to 
clarify whether "poorly" means "incorrectly" or "inefficiently" -- will 
I get the wrong answer, or will it just be doing more work than is 
strictly needed?

Lastly, I would be tempted to promote the motivation and comparison 
sections in your README up into the POD documentation to make it easier 
to find; this is crucial information and it took me a while to discover 
it.

-Simon