Re: [code-review] Bencode.pm

--- Caleb Epstein <[email protected]> wrote:
> 	I'm soliciting comments on the following Perl module,
> 	Bencode.pm, which implements in Perl "bencode"
> 	serialization and deserialization routines.

Just curious as to which existing encodings you examined and rejected and
why you rejected them?

Also, it's unclear from the documentation how general and robust your
data structure encoding is meant to be. For instance, bencode goes into
an infinite recursion when presented with circular references.

You definitely need to write some POD documentation for this module giving
some background, perhaps comparing and contrasting to similar encodings and
stating why you did it; a BUGS/CAVEATS section is needed explaining under
what circumstances your module will go into an infinite recursion. Some
examples and a regression test suite would be good too.

/-\


http://search.yahoo.com.au - Yahoo! Search
- Looking for more? Try the new Yahoo! Search