Re: DBD::Oracle copy/paste error
John Scoles <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.dbi.sybase.devel |
|---|---|
| Organization | The Pythian Group |
| Message-ID | <[email protected]> |
Thanks Milo I fixed that and committed it Subversion.
You will be gland to know that your name has now been added to PERL Monks
'Honour Roll of Open Source Developers'
as a
'*Jr Polliwog 2nd Class*'.
Welcome to the Dark Side your pocket protector and secret decoder ring
are in the mail.
Cheers
John Scoles
Milo van der Leij wrote:
> Before contributing something that is actually valuable, I'll use
> my very first open-source contribution on some low-hanging fruit.
>
> It looks like the person who copied ora_lob_length from
> ora_lob_trim missed something.
>
> Index: Oracle.xs
> ===================================================================
> --- Oracle.xs (revision 11560)
> +++ Oracle.xs (working copy)
> @@ -456,7 +456,7 @@
> CODE:
> OCILobGetLength_log_stat(imp_dbh->svchp, imp_dbh->errhp,
> locator, &len, status);
> if (status != OCI_SUCCESS) {
> - oci_error(dbh, imp_dbh->errhp, status, "OCILobTrim");
> + oci_error(dbh, imp_dbh->errhp, status, "OCILobGetLength");
> ST(0) = &sv_undef;
> }
> else {
>
>
> Regards,
> Milo
>
>
>