Re: DBD::Oracle DRCP_1.25

Index: Oracle.pm
===================================================================
--- Oracle.pm	(revision 14227)
+++ Oracle.pm	(working copy)
@@ -227,14 +227,26 @@
 	# create a 'blank' dbh
 
 	$user = '' if not defined $user;
-        (my $user_only = $user) =~ s:/.*::;
-        
-        if (substr($dbname,-7,7) eq ':POOLED'){
-           $dbname=substr($dbname,0,-7);
-           $attr->{ora_drcp} = 1;
+    (my $user_only = $user) =~ s:/.*::;
+    
+    if (substr($dbname,-7,7) eq ':POOLED'){
+       $dbname=substr($dbname,0,-7);
+       $attr->{ora_drcp} = 1;
+    }
+    elsif ($ENV{ORA_DRCP}){ 
+        $attr->{ora_drcp} = 1;
+        if (exists $ENV{ORA_POOL_CLASS}) {
+            $attr->{ora_pool_class} = $ENV{ORA_POOL_CLASS}
         }
-        elsif ($ENV{ORA_DRCP}){ 
-	   $attr->{ora_drcp} = 1;
+        if (exists $ENV{ORA_POOL_MIN}) {
+            $attr->{ora_pool_min} = $ENV{ORA_POOL_MIN}
+        }
+        if (exists $ENV{ORA_POOL_MAX}) {
+            $attr->{ora_pool_max} = $ENV{ORA_POOL_MAX}
+        }
+        if (exists $ENV{ORA_POOL_INCR}) {
+            $attr->{ora_pool_incr} = $ENV{ORA_POOL_INCR}
+        }
 	}
 	
 	my ($dbh, $dbh_inner) = DBI::_new_dbh($drh, {
@@ -1346,7 +1358,7 @@
 
   $dbh = DBI->connect('dbi:Oracle:','username@DB:POOLED','password')
   
-  $dbh = DBI->connect('dbi:Oracle:DB','username','password',{ora_drcp=>1})
+  $dbh = DBI->connect('dbi:Oracle:DB','username','password',{ora_drcp=>1, ora_pool_class=>'my_app', ora_pool_min=>10})
 
   $dbh = DBI->connect('dbi:Oracle:host=foobar;sid=ORCL;port=1521;SERVER=POOLED', 'scott/tiger', '')
 
@@ -1354,7 +1366,7 @@
   (ADDRESS=(PROTOCOL=TCP)(HOST= foobar)(PORT=1521))
   (CONNECT_DATA=(SID=ORCL)(SERVER=POOLED)))}, "")
 
-  if ORA_DRCP environemt var is set the just this
+  if ORA_DRCP and ORA_POOL_CLASS environemt var are set you could use just this
   
   $dbh = DBI->connect('dbi:Oracle:DB','username','password')
  
@@ -1530,13 +1542,60 @@
 
 =item ora_drcp
 
-If you have an 11.2 or greater database your can utilize the the DRCP by setting
-this attribute to 1 at connect time. 
+If you have an 11.2 or greater database your can utilize the the DRCP 
+(Database Resident Connection Pooling) by setting this attribute to 1 
+at connect time. 
 
 For convenience I have added support for a 'ORA_DRCP'
 environment variable that you can use at the OS level to set this
 value.  If used it will take the value at the connect stage.
 
+=item ora_pool_class
+
+If you use DRCP, you could set CONNECTION_CLASS at connection time.
+
+The connections are pooled based on unique SID/USERNAME/CONNECTION_CLASS.
+If you do not set the class attribute the connections will be pooled only
+within the boundaries of the process, becoming equivalent to a plain 
+client-side session pooling application. 
+
+For convenience I have added support for a 'ORA_POOL_CLASS'
+environment variable that you can use at the OS level to set this
+value. It will be used only if you use 'ORA_DRCP' environment variable.
+If used it will take the value at the connect stage.
+
+=item ora_pool_min
+
+If you use DRCP, you could set initial servers in the pool that will get
+started. Default value is 4 as per DBMS_CONNECTION_POOL default.
+
+For convenience I have added support for a 'ORA_POOL_MIN'
+environment variable that you can use at the OS level to set this
+value. It will be used only if you use 'ORA_DRCP' environment variable.
+If used it will take the value at the connect stage.
+
+
+=item ora_pool_max
+
+If you use DRCP, you could set maximum servers in the pool. Default value 
+is 40 as per DBMS_CONNECTION_POOL default.
+
+For convenience I have added support for a 'ORA_POOL_MAX'
+environment variable that you can use at the OS level to set this
+value. It will be used only if you use 'ORA_DRCP' environment variable.
+If used it will take the value at the connect stage.
+
+=item ora_pool_incr
+
+If you use DRCP, you could set how much new servers will get started if all
+servers in the pool are busy. Default value is 2 as per DBMS_CONNECTION_POOL
+default.
+
+For convenience I have added support for a 'ORA_POOL_INCR'
+environment variable that you can use at the OS level to set this
+value. It will be used only if you use 'ORA_DRCP' environment variable.
+If used it will take the value at the connect stage.
+
 =item ora_session_mode
 
 The ora_session_mode attribute can be used to connect with SYSDBA