Re: 51dbm_file.t problems in latest development release

  On 07/09/2010 19:57, Martin J. Evans wrote:
>  After a small discussion on #perl today I found a small amount of 
> time to look at 51dbm_file.t test failures. There are a few things I 
> noted:
>
> 1. ribasushi suggests the tests fail because it does a rmtree when 
> still connected so the files are still open and this fails on Windows. 
> I don't see this problem but I imagine it would be solved by 
> disconnecting, rmtree then reconnecting.
>
> 2. I'm a bit suspicious about the:
>
> $test_dir .= "_" . basename($0, qr/\.[^.]*/);
>
> in lib.t because basename docs say:
> "@suffixes work as in fileparse() except all regex metacharacters are 
> quoted" so those '*' and []^ will be taken literally. It does work if 
> you just change that to ".t".
>
> 3. personally I don't like ok calls without a test name as it makes it 
> hard to find the tests when looking at the code and comparing it with 
> the test output.
>
> 4. the test that fails for me is test 7 which does a:
>
> select * from 
> C:\Users\martin\DBI-1.613_93\test_output_5084_51dbm_file_mine\fred
>
> which returns no rows. I'm not sure why as that is the name of the file.
>
> I'd be happy to fix (2) and (3) and I don't think (1) will hurt but as 
> I cannot reproduce a problem with the rmtree as reported by some. 
> Instead the error I see is the last select which returns nothing.
>
> Martin
>
>
I've not tried the subversion trunk and it passed successfully.

I'll consider changing (2) and (3) tomorrow.

Martin