Re: ANNOUNCE: DBD::Oracle 1.25 Release Candidate 3

On 09/09/10 20:27, John Scoles wrote:
> Well the third time is a charm!!  We hope for the 'two bit' version of
> DBD::Oracle 1.25
> 
> You can find release candidate 3 here
> 
> http://svn.perl.org/modules/dbd-oracle/trunk/DBD-Oracle-1.25-RC3.tar
> 
> I got rid of the warning error in the .xs file for
> OCILobLocatorIsInit_log_stat seems it was a typo on my part. As well got
> rid of some harmless compiler warnings
> 
> Cheers
> John Scoles
> 
> -- 
> The best compliment you could give Pythian for our service is a referral.
> 

You didn't make the change I asked for a week ago for DBISTATE -> 

> To fix the DiscardString issue above could you please change
>
> #if DBISTATE_VERSION > 94
>
> to
>
> #if DBIXS_REVISION >= 13590
>
> in oci8.c around line 3793.
>
> Thanks.

I'd be really grateful if you did as it stops DiscardString working with later DBI versions.

Also the following small change at line 2443 of dbdimp.c avoids

dbdimp.c:2443: warning: format ‘%d’ expects type ‘int’, but argument 5 has type ‘IV’

PerlIO_printf(DBILOGFP, "size %ld/%ld/%"IVdf", ",(long)SvCUR(phs->sv),(long)SvLEN(phs->sv),phs->maxlen);

For Instant Client 11.1 and Oracle 11.1 I got the usual 1 failure in 26exe_array.

Test Summary Report
-------------------
t/26exe_array.t       (Wstat: 512 Tests: 17 Failed: 2)
  Failed tests:  11, 14
  Non-zero exit status: 2
Files=31, Tests=2293, 18 wallclock secs ( 0.44 usr  0.04 sys +  5.29 cusr  0.62 csys =  6.39 CPU)
Result: FAIL
Failed 1/31 test programs. 2/2293 subtests failed.
make: *** [test_dynamic] Error 255

Have not tested it with our application yet but will as the last one was getting a segfault in some of the lob reading code - I think Tux (H.Merijn Brand)was getting that too.

Martin
-- 
Martin J. Evans
Easysoft Limited
http://www.easysoft.com