Re: [PATCH] DBD::Pg configuration setup

On Oct 15, 2010, at 7:43 AM, H.Merijn Brand wrote:

> Good enough for now.
> 
> And here's the patch. FWIW HP-UX 9 is so archaic that even /I/ do not
> have access to it anymore :)
> 
> --8<---
> --- Makefile.PL.org     2010-04-07 22:52:55 +0200
> +++ Makefile.PL 2010-10-15 16:35:35 +0200
> @@ -211,19 +211,16 @@ my %opts =
>         PERL_MALLOC_OK => 1,
>         NEEDS_LINKING  => 1,
>         NO_META        => 1,
> -     NORECURS       => 1,
> +        NORECURS       => 1,
>         clean          => { FILES => 'trace Pg.xsi README.testdatabase' },
> -     realclean      => { FILES => 'dbdpg_test_database/' },
> +        realclean      => { FILES => 'dbdpg_test_database/' },
> +        macro          => {
> +           LDFLAGS     => "-L$POSTGRES_LIB $Config{ldflags}",
> +           LDDLFLAGS   => "-L$POSTGRES_LIB $Config{lddlflags}",
> +       },
> );
> 
> -if ($os eq 'hpux') {
> -    my $osvers = $Config{osvers};
> -    if ($osvers < 10) {
> -        print "Warning: Forced to build static not dynamic on $os $osvers.\a\n";
> -        $opts{LINKTYPE} = 'static';
> -    }
> -}
> -elsif ($os =~ /Win32/) {
> +if ($os =~ /Win32/) {
>        my $msdir = $POSTGRES_LIB;
>        $msdir =~ s{"$}{/ms"};
>        $opts{LIBS}[0] .= " -L$msdir -lsecur32";
> -->8---

Seems like a pretty straight-forward patch. Happy to see one OS-specific hack removed.

David