Re: SQL::Statement 1.31_001 dev-release and test rewrite

On Thu, 06 Jan 2011 11:08:15 +0000, Jens Rehsack
<[email protected]> wrote:

> On 01/01/11 07:55, Michael G Schwern wrote:
> > On 2011.1.1 12:38 AM, Jens Rehsack wrote:
> >> Further I need some help on test rewrite (that's why you, Michael
> >> Schwern, are on CC).
> >> I'd like to rewrite step by step all tests like I did in t/06virtual.t
> >> and t/08join.t. For this I
> >> have to move the test main loop into the TestLib.pm and I would prefer
> >> if I could setup
> >> Test::More to print the file name and the line of the real test
> >> (somewhere in the list of
> >> tests - where the tests need some additional fields).
> >
> > There's one of a number of things you might be trying to do here.  Mainly I
> > don't know what the "main loop" is.  If you rewrite the test how you want and
> > show me, I can show you how to fix the file/line numbers.  Likely it will be a
> > simple matter of C<  local $Test::Builder::Level = $Test::Builder::Level + 1>
> > in your loop routine.
> 
> That's only one step - I want the line numbers of the test, and the test is
> currently written as an hash-entry in a test-list.
> Probably it's wiser to create an own "sql_test" sub which contains the code
> from the test loop (see t/06virtual.t for an example).
> 
> > Also, your 1.31_001 alpha is actually $VERSION 1.32.  If this was intentional,
> > I would recommend against prematurely increasing the actual $VERSION.  It will
> > cause confusion with the real release, not everything respects the
> > distribution version (ie. what's on the tarball), and it's odd to unpack
> > Foo-1.23_01.tar.gz and get Foo-1.24.  Now that 1.32 is confused, I would
> > recommend you skip 1.32 and the next alphas be 1.32_0x.  Then the final
> > version be 1.33.
> 
> Yes, maybe - but this might confuse others ...
> I had chosen this kind of file renaming according to xdg's blog entry
> "version numbers should be boring".
> 
> > You're shipping .aspell.local.pws which looks like a local dictionary for a
> > spell checker.  Intentional?
> 
> You had to ask Tux (Merijn) about this - he added that file.

Not really meant to be distributed, but it does do no harm

That file (these files) are a list in aspell format, just like in $HOME

SS-svn> ls ~/.aspell*
/home/merijn/.aspell.de.prepl  /home/merijn/.aspell.en.pws
/home/merijn/.aspell.de.pws    /home/merijn/.aspell.nl.prepl
/home/merijn/.aspell.en.prepl  /home/merijn/.aspell.nl.pws

It is a list of words that are not in default dictionaries, but are
correct in the current documentation. Actually, it is now out-of-date

SS-svn > pod-spell-check --aspell
    ok 1 - lib/SQL/Dialects/ANSI.pm
    ok 2 - lib/SQL/Dialects/AnyData.pm
    ok 3 - lib/SQL/Dialects/CSV.pm
    ok 4 - lib/SQL/Dialects/Role.pm
    ok 5 - lib/SQL/Eval.pm
    ok 6 - lib/SQL/Parser.pm
    ok 7 - lib/SQL/Statement.pm
    ok 8 - lib/SQL/Statement/Function.pm
    ok 9 - lib/SQL/Statement/Functions.pm
    ok 10 - lib/SQL/Statement/GetInfo.pm
    ok 11 - lib/SQL/Statement/Operation.pm
    ok 12 - lib/SQL/Statement/Placeholder.pm
    ok 13 - lib/SQL/Statement/RAM.pm
    ok 14 - lib/SQL/Statement/Term.pm
    ok 15 - lib/SQL/Statement/TermFactory.pm
    ok 16 - lib/SQL/Statement/Util.pm
    ok 17 - t/SQLtest.pm
    ok 18 - t/TestLib.pm
    1..18
ok 1 - CommonMistakes
    ok 1 - lib/SQL/Dialects/ANSI.pm
    ok 2 - lib/SQL/Dialects/AnyData.pm
    ok 3 - lib/SQL/Dialects/CSV.pm
    ok 4 - lib/SQL/Dialects/Role.pm
    ok 5 - lib/SQL/Eval.pm
    ok 6 - lib/SQL/Parser.pm
    not ok 7 - lib/SQL/Statement.pm
    #   Failed test 'lib/SQL/Statement.pm'
    #   at /pro/bin/pod-spell-check line 94.
    #          got: ''kibbitz' => (kibbutz kibitz)'
    #     expected: ''
    ok 8 - lib/SQL/Statement/Function.pm
    ok 9 - lib/SQL/Statement/Functions.pm
    ok 10 - lib/SQL/Statement/GetInfo.pm
    ok 11 - lib/SQL/Statement/Operation.pm
    ok 12 - lib/SQL/Statement/Placeholder.pm
    ok 13 - lib/SQL/Statement/RAM.pm
    ok 14 - lib/SQL/Statement/Term.pm
    ok 15 - lib/SQL/Statement/TermFactory.pm
    ok 16 - lib/SQL/Statement/Util.pm
    ok 17 - t/SQLtest.pm
    ok 18 - t/TestLib.pm
    1..18
    # Looks like you failed 1 test of 18.
not ok 2 - Spell-check with aspell
#   Failed test 'Spell-check with aspell'
#   at /pro/bin/pod-spell-check line 98.
    1..0 # SKIP Ispell not selected
ok 3 # skip Ispell not selected
1..3
# Looks like you failed 1 test of 3.
SS-svn >

pod-spell-check is attached in case you might want to play with it

> > Finally, the disparity between the tarball name and the directory indicates
> > that you're not using "make dist" to create your tarball.  This risks picking
> > up things ignored by your MANIFEST.SKIP.
> 
> No - I did a "make test && mv $a $b"

-- 
H.Merijn Brand  http://tux.nl      Perl Monger  http://amsterdam.pm.org/
using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00,
11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.3 and AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/