Re: more on execute_array not complying with the specification

On 30/01/2011 17:46, Martin J. Evans wrote:
> Hi,
>
> I'm still working on and off with execute_array problems hoping to get 
> DBI and the spec to match and also investigating if the current 
> implementation covers all possibilities. I've now written a simple 
> test to see if it complies with the specification (and will include it 
> in DBD::ODBC) and I don't think it does. The main point is:
>
> the pod says:
>
> "The |ArrayTupleStatus| attribute can be used to specify a reference 
> to an array which will receive the execute status of each executed 
> parameter tuple. Note the |ArrayTupleStatus| attribute was mandatory 
> until DBI 1.38.
>
> For tuples which are successfully executed, the element at the same 
> ordinal position in the status array is the resulting rowcount. If the 
> execution of a tuple causes an error, then the corresponding status 
> array element will be set to a reference to an array containing the 
> error code and error string set by the failed execution."
>
> but the test shows the ArrayTupleStatus contains 3 elements on an 
> error and not "an array containing the error code and error string set 
> by the failed execution".
>
> e.g.,:
>
> # $VAR1 = [
> #           1,
> #           1,
> #           1,
> #           [
> #             1,
> #             '[unixODBC][Easysoft][SQL Server Driver 10.0][SQL 
> Server]Violation
>  of PRIMARY KEY constraint \'PK__PERL_DBD__3BD0198E526429B0\'. Cannot 
> insert dup
> licate key in object \'dbo.PERL_DBD_execute_array\'. (SQL-23000) 
> [state was 2300
> 0 now 01000]
> # [unixODBC][Easysoft][SQL Server Driver 10.0][SQL Server]The 
> statement has been
>  terminated. (SQL-01000)',
> #             '01000'
> #           ],
> #           1
> #         ];
>
> It is down to the following line of code:
>
> push @$tuple_status, [ $sth->err, $sth->errstr, $sth->state ];
>
>
> so I guess the pod should say:
>
> "If the execution of a tuple causes an error, then the corresponding 
> status array element will be set to a reference to an array containing 
> the err, errstr and state set by the failed execution. If that is the 
> case let me know and I'll amend the pod. Otherwise, I'll need to know 
> what was intended.
>
> Attached is my current test code but I'm still working on it. In 
> particular, I've not found an ODBC driver which aborts on the first 
> insert failure yet.
>
> Martin
I know there is a danger than I'm looking impatient on this (and I 
apologise for this) and you (Tim) may be busy/away but I could really do 
with an answer on this as I've added the test code for DBD::ODBC and 
currently it fails because the pod says 2 fields per error and DBI sets 
3 fields per error in ArrayTupleStatus. Also, DBD::Oracle is close to 
release and it sets 2 fields per error currently.

Martin