Re: 1.617 smoke results

On Thu, Feb 09, 2012 at 10:14:53AM +0000, Martin J. Evans wrote:
> On 09/02/12 09:15, Martin J. Evans wrote:
> >I've been testing 1.617 on our development system and have not encountered any problems as yet. However, I notice a few UNKNOWN smoke reports like the following one (on mac):
> >
> >http://www.cpantesters.org/cpan/report/ddd9ac12-5074-11e1-823e-1c11842dab9b
> >
> >It appears the archname on some Perls for OSX is "archname=darwin-debug-nothreads" when useithreads=undef and DBI does:
> >
> >$::opt_thread = 1; # thread if we can, use "-nothread" to disable
> >if ($Config{useithreads}) {
> >$::opt_thread = 1;
> >} else {
> >if ($Config{archname} =~ /thread/ && $::opt_thread) {
> >...
> >die "*** ABORTED.\n";
> >}
> >$::opt_thread = 0;
> >}
> >
> >Any reason not to change that to exclude "nothread".

I'll change the regex to /\bthread/ - that should do it.

> In addition, tests are failing (http://www.cpantesters.org/cpan/report/53db7354-4ee6-11e1-9874-b2933f3ac79b) because people have PERL_UNICODE set to SAL. The failure is:
> 
> #   Failed test 'pipeone: DBI connect('transport=pipeone;policy=pedantic;perl=/home/mauke/usr/local/bin/perl  -Mblib=/home/mauke/.cpan/build/DBI-1.617-meDLEf/blib;timeout=240;dsn=DBI:DBM:f_dir=/home/mauke/.cpan/build/DBI-1.617-meDLEf/test_output_7531/000_just_testing;dbm_type=SDBM_File;f_lockfile=0','',...) failed: DBD::Gofer::Transport::pipeone command (/home/mauke/usr/local/bin/perl -Mblib=/home/mauke/.cpan/build/DBI-1.617-meDLEf/blib -MDBI::Gofer::Transport::pipeone -e run_one_stdio) failed: utf8 "\x81" does not map to Unicode at /home/mauke/.cpan/build/DBI-1.617-meDLEf/blib/lib/DBI/Gofer/Transport/pipeone.pm line 27, <STDIN> chunk 1.
> # Error thawing: Frozen string corrupt - contains characters outside 0-255 at /home/mauke/usr/local/lib/perl5/5.14.2/i686-linux/Storable.pm line 416, <STDIN> line 1, at /home/mauke/.cpan/build/DBI-1.617-meDLEf/blib/lib/DBI/Gofer/Serializer/Storable.pm line 56 (data="GoFER1:&#5;&#8;DBI::Gofer::Request&#3;), pid 7532 stack trace follows: at /home/mauke/.cpan/build/DBI-1.617-meDLEf/blib/lib/DBI/Gofer/Transport/Base.pm line 98, <STDIN> line 1
> [...]

There's a ticket for this "Gofer test failures with PERL_UNICODE=AS":
https://rt.cpan.org/Public/Bug/Display.html?id=71341

> Should we skip those tests when PERL_UNICODE is set?

I'd rather not sweep those failures under the carpet.

It's probably a simple fix (set the file handle to binary) but I've not
got around to looking into it.

Any volunteers?

Tim.