Compiler warnngs (was: ANNOUNCE DBI 1.618)

On Sat, Feb 25, 2012 at 02:18:56PM -0800, Jonathan Leffler wrote:
> 
>    The compilation phase has a couple of warnings with the compiler set very fussy...I doubt if they're
>    significant, but just in case they're fixable and fixworthy:
> 
>    Perl.c: In function ‘XS_DBD__Perl__dr_data_sources’:
>    Perl.c:262:7: warning: variable ‘attr’ set but not used [-Wunused-but-set-variable]
>    Perl.c: In function ‘XS_DBD__Perl__db__login’:
>    Perl.c:306:7: warning: variable ‘attribs’ set but not used [-Wunused-but-set-variable]
>    Perl.c: In function ‘XS_DBD__Perl__db_last_insert_id’:
>    Perl.c:538:7: warning: variable ‘attr’ set but not used [-Wunused-but-set-variable]

Perl.xs is a weird kind of hack that exists just to do a basic sanity
check of Driver.xst. Does this change in Perl.xs silence the first
warning?:

-#define dbd_dr_data_sources(drh, imp_drh, attr) (drh=drh,imp_drh=imp_drh,Nullav)
+#define dbd_dr_data_sources(drh, imp_drh, attr) (drh=drh,imp_drh=imp_drh,attr)

>    DBI.xs: In function ‘XS_DBI_dispatch’:
>    DBI.xs:282:14: warning: ‘c’ may be used uninitialized in this function [-Wuninitialized]
>    DBI.xs:227:21: note: ‘c’ was declared here

I think that one's not a problem (and Dave's has reworked the method
cache so it'll change for the next release).

Tim.