RE: Patch proposal for leak in DBD::Oracle when calling 'execute_array' with UTF-8 NLS...
John Scoles <[email protected]>
| Newsgroups | gmane.comp.lang.perl.modules.dbi.sybase.devel |
|---|---|
| Message-ID | <[email protected]> |
Opps you are right Should read perlguts again. Looking again putting the tuples_utf8_av in the iteration may work but perhapse one should use 'sv_2mortal' at some point in the into to take care of the garbage collection for us. Like I said I only had a quick look at it. My preferace is to let XS take case for any decrementing for us, is my point I was trying to get across. cheers John ---------------------------------------- > Date: Tue, 9 Oct 2012 16:57:05 +0200 > Subject: Re: Patch proposal for leak in DBD::Oracle when calling 'execute_array' with UTF-8 NLS... > From: [email protected] > To: [email protected] > CC: [email protected]; [email protected]; [email protected] > > On 9 October 2012 14:29, John Scoles <[email protected]> wrote: > > > > I am sort of with Martin on this one as we would like to know why? > > > > At first glace decrementing the reference count like this would not seem to be a little overkill as tuples_utf8_av is created with newAV() which should take care of that for us. > > Should take care of what? > > newAV() doesnt create a mortal. > > Yves > > > -- > perl -Mre=debug -e "/just|another|perl|hacker/"