Re: some fixes / new test for DBD::CSV

On Fri, 26 Oct 2012 16:58:13 +0200, Jens Rehsack
<[email protected]> wrote:

> Hi Merijn,
> 
> as talked in IRC here are the patches. They currently cover the 2 things
> I missed tests for (file-handle, col_names + skip_rows).
> 
> You can do me a favour and apply the attached patches using
> 'git am' and modify them later (allows me to fast-forward instead
> of merging).

I did, but this isn't good:

DBD-CSV 509 > prove -vwb t/61_meta.t
t/61_meta.t .. plan() doesn't understand skipall DBD::File 0.41 required at t/61_meta.t line 12.
Use of uninitialized value $fn in unlink at t/61_meta.t line 54.
Dubious, test returned 22 (wstat 5632, 0x1600)
No subtests run

Test Summary Report
-------------------
t/61_meta.t (Wstat: 5632 Tests: 0 Failed: 0)
  Non-zero exit status: 22
  Parse errors: No plan found in TAP output
Files=1, Tests=0,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.07 cusr  0.00 csys =  0.09 CPU)
Result: FAIL

I fixed those in the commit after yours (+ tidying)

Requiring DBD::File-0.41 also implies requiring the non-released
DBI-6.123

Setting my env to use that unreleased DBI, I get

CPAN/DBD-CSV 523 > prove -vwb t/61_meta.t
t/61_meta.t ..
ok 1 - find new test table
ok 2 # skip memory i/o currently unsupported by DBD::File
ok 3 # skip memory i/o currently unsupported by DBD::File
DBD::CSV::st execute failed: Can't use an undefined value as a symbol reference at /pro/3gl/CPAN/DBI-svn/blib/lib/DBD/File.pm line 445, <DATA> line 7. at /pro/3gl/CPAN/DBI-svn/blib/lib/DBI/DBD/SqlEngine.pm line 1191.
 [for Statement "SELECT * FROM data"] at t/61_meta.t line 73, <DATA> line 7.
DBD::CSV::st fetchall_arrayref failed: Attempt to fetch row without a preceeding execute () call or from a non-SELECT statement [for Statement "SELECT * FROM data"] at t/61_meta.t line 74, <DATA> line 7.
not ok 4 - all rows found - file-handle w/o col_names

#   Failed test 'all rows found - file-handle w/o col_names'
#   at t/61_meta.t line 75.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = ARRAY(0x9145bfc)
not ok 5 - column names - file-handle w/o col_names

#   Failed test 'column names - file-handle w/o col_names'
#   at t/61_meta.t line 76.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = 'id'
DBD::CSV::st execute failed: Can't use an undefined value as a symbol reference at /pro/3gl/CPAN/DBI-svn/blib/lib/DBD/File.pm line 445, <DATA> line 7. at /pro/3gl/CPAN/DBI-svn/blib/lib/DBI/DBD/SqlEngine.pm line 1191.
 [for Statement "SELECT * FROM data"] at t/61_meta.t line 88, <DATA> line 7.
DBD::CSV::st fetchall_arrayref failed: Attempt to fetch row without a preceeding execute () call or from a non-SELECT statement [for Statement "SELECT * FROM data"] at t/61_meta.t line 89, <DATA> line 7.
not ok 6 - all rows found - file-handle w col_names

#   Failed test 'all rows found - file-handle w col_names'
#   at t/61_meta.t line 90.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = ARRAY(0x9145bfc)
not ok 7 - column names - file-handle w col_names

#   Failed test 'column names - file-handle w col_names'
#   at t/61_meta.t line 91.
#     Structures begin differing at:
#          $got->[0] = Does not exist
#     $expected->[0] = 'foo'
ok 8 - all rows found - file-name w/o col_names
ok 9 - column names - file-name w/o col_names
ok 10 - all rows found - file-name w col_names
ok 11 - column names - file-name w col_names
1..11
# Looks like you failed 4 tests of 11.
Dubious, test returned 4 (wstat 1024, 0x400)
Failed 4/11 subtests
        (less 2 skipped subtests: 5 okay)

Test Summary Report
-------------------
t/61_meta.t (Wstat: 1024 Tests: 11 Failed: 4)
  Failed tests:  4-7
  Non-zero exit status: 4
Files=1, Tests=11,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.08 cusr  0.00 csys =  0.09 CPU)
Result: FAIL

Pushed anyway, so you can move on …

> Thanks,
> Jens

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.17   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/