[perl5-dbi/dbi] 176ffe: Callbacks ought not to be passed inline to connect...

"H.Merijn Brand - Tux" <[email protected]>
Newsgroups gmane.comp.lang.perl.modules.dbi.sybase.devel
Message-ID <52580a418f744_285c1387d588881a@hookshot-fe4-pe1-prd.aws.github.net.mail>
  Branch: refs/heads/dbi-test-conditional
  Home:   https://github.com/perl5-dbi/dbi
  Commit: 176ffe9509eeb3bfabec058247e09378f51242c0
      https://github.com/perl5-dbi/dbi/commit/176ffe9509eeb3bfabec058247e09378f51242c0
  Author: David E. Wheeler <[email protected]>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M DBI.pm

  Log Message:
  -----------
  Callbacks ought not to be passed inline to connect_cached.

So mention that fact in the callbacks documentation.


  Commit: dbadce943a501a39668b58eb52227c23851690bf
      https://github.com/perl5-dbi/dbi/commit/dbadce943a501a39668b58eb52227c23851690bf
  Author: David E. Wheeler <[email protected]>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M DBI.pm
    M t/70callbacks.t

  Log Message:
  -----------
  Add the `connect_cached.connected` callback.

It is only called for new connections, right after they connect. This is
because the `connected()` method is not called, for whatever reason.


  Commit: 60c2ee3965912dfc0faaa6d4265a16e4362da6a6
      https://github.com/perl5-dbi/dbi/commit/60c2ee3965912dfc0faaa6d4265a16e4362da6a6
  Author: David E. Wheeler <[email protected]>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M DBI.pm

  Log Message:
  -----------
  Note the reason for connect_cached.connected.

It is to do something after a new connection is made. One can use a
`connected` callback, but that's called for both new and reused connections,
which is probably not desirable.


  Commit: d157cf06670f9e65a5340c86aae33c087bc8a793
      https://github.com/perl5-dbi/dbi/commit/d157cf06670f9e65a5340c86aae33c087bc8a793
  Author: Tim Bunce <[email protected]>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M DBI.pm

  Log Message:
  -----------
  Merge pull request #2 from theory/cb-doctweak

Callbacks ought not to be passed inline to connect_cached.


  Commit: 1ca8130571de3d35b6eec83a22e3e47cfc808138
      https://github.com/perl5-dbi/dbi/commit/1ca8130571de3d35b6eec83a22e3e47cfc808138
  Author: Tim Bunce <[email protected]>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M Changes
    M DBI.pm
    M t/70callbacks.t

  Log Message:
  -----------
  Added connect_cached.connected Callback PR#3 [David E. Wheeler]

Merge remote-tracking branch 'origin/pr/3'


  Commit: e90c3db6b8128cd9841358e352dc66ad56279de0
      https://github.com/perl5-dbi/dbi/commit/e90c3db6b8128cd9841358e352dc66ad56279de0
  Author: Tim Bunce <[email protected]>
  Date:   2013-09-25 (Wed, 25 Sep 2013)

  Changed paths:
    M Changes
    M DBI.xs

  Log Message:
  -----------
  Clarify wording of log message when err is cleared.

Re http://stackoverflow.com/questions/18983601/why-is-there-a-0-cleared-by-call-to-connect-method-warning-in-dbi-trace


  Commit: 0456c23362dabf5bf079fce12e9cb78cd1b200a5
      https://github.com/perl5-dbi/dbi/commit/0456c23362dabf5bf079fce12e9cb78cd1b200a5
  Author: Martin J. Evans <[email protected]>
  Date:   2013-09-26 (Thu, 26 Sep 2013)

  Changed paths:
    M Changes
    M DBI.pm

  Log Message:
  -----------
  Stop setting err to 0 when creating a new drh


  Commit: b6865b8c6a6505ac220ba6ffc306e99cad5a5c45
      https://github.com/perl5-dbi/dbi/commit/b6865b8c6a6505ac220ba6ffc306e99cad5a5c45
  Author: Martin J. Evans <[email protected]>
  Date:   2013-09-26 (Thu, 26 Sep 2013)

  Changed paths:
    M Changes
    M DBI.pm

  Log Message:
  -----------
  Fix RT#83132 - move DBIstcf* constants to utils export group


  Commit: 3b2d8216f2028040dc6b2b1d1b3ebcfaa264a3ae
      https://github.com/perl5-dbi/dbi/commit/3b2d8216f2028040dc6b2b1d1b3ebcfaa264a3ae
  Author: Martin J. Evans <[email protected]>
  Date:   2013-09-28 (Sat, 28 Sep 2013)

  Changed paths:
    M Changes
    M DBI.pm

  Log Message:
  -----------
  Clarification of ReadOnly attribute when driver cannot enforce it


  Commit: 067ef159325ee75eb06aaf280650bcf2a86ed00b
      https://github.com/perl5-dbi/dbi/commit/067ef159325ee75eb06aaf280650bcf2a86ed00b
  Author: Martin J. Evans <[email protected]>
  Date:   2013-09-28 (Sat, 28 Sep 2013)

  Changed paths:
    M .gitignore

  Log Message:
  -----------
  ignore a load of generated files in .gitignore

On Windows, a load of files get generated which the .gitignore does not
ignore


  Commit: 571608687d4741f083caf34e9f3037735623bfc3
      https://github.com/perl5-dbi/dbi/commit/571608687d4741f083caf34e9f3037735623bfc3
  Author: Tim Bunce <[email protected]>
  Date:   2013-09-28 (Sat, 28 Sep 2013)

  Changed paths:
    A .gdbinit
    M .gitignore

  Log Message:
  -----------
  Sorted .gitignore, added test_output_* and MYMETA.*. Added .gdbinit


  Commit: a9d245952e912675f047a3a960624a07a67693a1
      https://github.com/perl5-dbi/dbi/commit/a9d245952e912675f047a3a960624a07a67693a1
  Author: Dagfinn Ilmari Mannsåker <[email protected]>
  Date:   2013-09-29 (Sun, 29 Sep 2013)

  Changed paths:
    M DBI.pm

  Log Message:
  -----------
  Fix POD for SQL_BIGINT type constant

It's exported as of DBI-1.54, with the ODBC value.


  Commit: 2b891cb93beae60654a6a7958c91a361e5e14487
      https://github.com/perl5-dbi/dbi/commit/2b891cb93beae60654a6a7958c91a361e5e14487
  Author: Tim Bunce <[email protected]>
  Date:   2013-09-29 (Sun, 29 Sep 2013)

  Changed paths:
    M DBI.pm

  Log Message:
  -----------
  Merge pull request #5 from ilmari/fix-bigint-pod

Fix POD for SQL_BIGINT type constant


  Commit: 9292649cd0e73be76a1e21f768f94bd7d884c5ff
      https://github.com/perl5-dbi/dbi/commit/9292649cd0e73be76a1e21f768f94bd7d884c5ff
  Author: Tim Bunce <[email protected]>
  Date:   2013-09-29 (Sun, 29 Sep 2013)

  Changed paths:
    M Changes

  Log Message:
  -----------
  Added Changes for PR5 and polished wordings


  Commit: 58ef040c6bd583fc72005981b54e9181bdc48a7d
      https://github.com/perl5-dbi/dbi/commit/58ef040c6bd583fc72005981b54e9181bdc48a7d
  Author: Tim Bunce <[email protected]>
  Date:   2013-10-10 (Thu, 10 Oct 2013)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Add perl 5.18 to .travis.yml


  Commit: 70fe6bd760c1d31326b47e4955f498bf2d1b3127
      https://github.com/perl5-dbi/dbi/commit/70fe6bd760c1d31326b47e4955f498bf2d1b3127
  Author: Tim Bunce <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Changes
    M DBI.pm
    M DBI.xs
    M DBIXS.h
    M lib/DBD/ExampleP.pm
    M lib/DBD/Gofer.pm
    M lib/DBD/NullP.pm
    M lib/DBI/PurePerl.pm
    M t/06attrs.t
    M t/08keeperr.t

  Log Message:
  -----------
  Added ErrChangeCount attr to fix PrintWarn for STROE etc. RT#89015.


  Commit: e51119ea83336d7b28b974fbd35f8c050c4f081b
      https://github.com/perl5-dbi/dbi/commit/e51119ea83336d7b28b974fbd35f8c050c4f081b
  Author: Tim Bunce <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Changes
    M DBI.pm

  Log Message:
  -----------
  No longer show quote and quote_identifier calls at trace level 1.


  Commit: e190b789ba8b0a7bd77d4905b716efa633c6533f
      https://github.com/perl5-dbi/dbi/commit/e190b789ba8b0a7bd77d4905b716efa633c6533f
  Author: Tim Bunce <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Changes
    M DBI.pm
    M DBI.xs
    M lib/DBI/PurePerl.pm

  Log Message:
  -----------
  Enable PrintWarn by default. (Trial for testing by developers.)


  Commit: f8129c93937e4e3c97b61e3bf9bf283ca7dcb940
      https://github.com/perl5-dbi/dbi/commit/f8129c93937e4e3c97b61e3bf9bf283ca7dcb940
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Makefile.PL

  Log Message:
  -----------
  add DBI::Test dependency


  Commit: d15d1a9839cd61d5fb65c67618a4b8f9c0b1efa3
      https://github.com/perl5-dbi/dbi/commit/d15d1a9839cd61d5fb65c67618a4b8f9c0b1efa3
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    A lib/DBI/Test/DBI/Conf.pm
    A lib/DBI/Test/DBI/List.pm

  Log Message:
  -----------
  add skeleton for DBI plugins for DBI::Test


  Commit: 1f9c24bdea5d590e0799d24c8edbfd532d024b03
      https://github.com/perl5-dbi/dbi/commit/1f9c24bdea5d590e0799d24c8edbfd532d024b03
  Author: Joakim <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    A lib/DBI/Test/DBI/Case/attributes/Active.pm
    A lib/DBI/Test/DBI/Case/attributes/ActiveKids.pm
    A lib/DBI/Test/DBI/Case/attributes/CachedKids.pm
    A lib/DBI/Test/DBI/Case/attributes/Executed.pm
    A lib/DBI/Test/DBI/Case/attributes/Kids.pm
    A lib/DBI/Test/DBI/Case/attributes/Type.pm

  Log Message:
  -----------
  Inital test files. To be updated


  Commit: 5b220dc9008b9748efdaf24bd62ae1a30beb8937
      https://github.com/perl5-dbi/dbi/commit/5b220dc9008b9748efdaf24bd62ae1a30beb8937
  Author: Joakim <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M lib/DBI/Test/DBI/Case/attributes/ActiveKids.pm
    M lib/DBI/Test/DBI/Case/attributes/Kids.pm
    M lib/DBI/Test/DBI/Case/attributes/Type.pm

  Log Message:
  -----------
  Fixed typo. Test now runs without dying


  Commit: 7dcf56b0d8775a9d46bf33b189718bad0dc8e836
      https://github.com/perl5-dbi/dbi/commit/7dcf56b0d8775a9d46bf33b189718bad0dc8e836
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    A lib/DBI/Test/Case/DBI/attributes/Active.pm
    A lib/DBI/Test/Case/DBI/attributes/ActiveKids.pm
    A lib/DBI/Test/Case/DBI/attributes/CachedKids.pm
    A lib/DBI/Test/Case/DBI/attributes/Executed.pm
    A lib/DBI/Test/Case/DBI/attributes/Kids.pm
    A lib/DBI/Test/Case/DBI/attributes/Type.pm
    R lib/DBI/Test/DBI/Case/attributes/Active.pm
    R lib/DBI/Test/DBI/Case/attributes/ActiveKids.pm
    R lib/DBI/Test/DBI/Case/attributes/CachedKids.pm
    R lib/DBI/Test/DBI/Case/attributes/Executed.pm
    R lib/DBI/Test/DBI/Case/attributes/Kids.pm
    R lib/DBI/Test/DBI/Case/attributes/Type.pm

  Log Message:
  -----------
  rename testcases to basename DBI::Test::Case

rename testcases to basename DBI::Test::Case, 'cause it's always prepended


  Commit: 56aff3db94aa62db90457111310e7b87ebedda23
      https://github.com/perl5-dbi/dbi/commit/56aff3db94aa62db90457111310e7b87ebedda23
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Makefile.PL
    A lib/DBI/Test/Case/DBI/simple/dbm.pm
    A lib/DBI/Test/Case/DBI/simple/file.pm
    A lib/DBI/Test/Case/DBI/simple/sql_engine.pm
    A lib/DBI/Test/DBI/Case.pm
    M lib/DBI/Test/DBI/Conf.pm
    A lib/DBI/Test/DBI/DSN/Provider/DBM.pm
    M lib/DBI/Test/DBI/List.pm
    R t/48dbi_dbd_sqlengine.t
    R t/49dbd_file.t
    R t/50dbm_simple.t
    R t/51dbm_file.t

  Log Message:
  -----------
  complete DBI::Test bootstrap

* add DBI::Test::DBI::Conf, List and Case
* introduce DBI::Test::DBI::Provider::DSN::DBM for DBD::DBM variants
* migrate basic DBD::File / DBD::DBM tests to DBI::Test


  Commit: 64268139ef400de6f20f35cb6340aee19399ab25
      https://github.com/perl5-dbi/dbi/commit/64268139ef400de6f20f35cb6340aee19399ab25
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M lib/DBD/DBM.pm

  Log Message:
  -----------
  load dbm_* utility packages ...

load dbm_* utility packages when determining version info


  Commit: 3db7db8f57feb039ad3ff41071cd68c938a4793f
      https://github.com/perl5-dbi/dbi/commit/3db7db8f57feb039ad3ff41071cd68c938a4793f
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M lib/DBI/Test/Case/DBI/simple/sql_engine.pm

  Log Message:
  -----------
  RootClass missing for test


  Commit: de62fc9ad5556268ed186da4610befefc95ff750
      https://github.com/perl5-dbi/dbi/commit/de62fc9ad5556268ed186da4610befefc95ff750
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Thank you riba travis whatever


  Commit: a730aac1404aa23fb0ce33def89e3f5063d0e1cd
      https://github.com/perl5-dbi/dbi/commit/a730aac1404aa23fb0ce33def89e3f5063d0e1cd
  Author: Peter Rabbitson <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  We want to verbosify cpanm before install commences


  Commit: c118a1fa17c398a4ced47ce193f0110d9c7e0d3b
      https://github.com/perl5-dbi/dbi/commit/c118a1fa17c398a4ced47ce193f0110d9c7e0d3b
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M MANIFEST

  Log Message:
  -----------
  Travis uses a dist checkout, so lib/DBI/Test files should be included


  Commit: 81498e1332a92e8eba1573af51e07639cd83daeb
      https://github.com/perl5-dbi/dbi/commit/81498e1332a92e8eba1573af51e07639cd83daeb
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Makefile.PL

  Log Message:
  -----------
  Make - for release 0.001 - DBI::Test conditional

I know we do want to force DBI::Test for the (very near) future, but
in this early stage, we want it to be easier for developers to make the
move is a more generous fashion. Having it depend on DBI::Test actually
being installed makes it easier to run the same version twice in say
PerlBrew environments with and without DBI::Test


  Commit: 3e17ef713d69c3134d7e1aa49d12e24b9789695e
      https://github.com/perl5-dbi/dbi/commit/3e17ef713d69c3134d7e1aa49d12e24b9789695e
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    A t/48dbi_dbd_sqlengine.t
    A t/49dbd_file.t
    A t/50dbm_simple.t
    A t/51dbm_file.t

  Log Message:
  -----------
  Restore old tests and run them conditional


  Commit: 195637079056d594ae5b73c97158b89d26886edf
      https://github.com/perl5-dbi/dbi/commit/195637079056d594ae5b73c97158b89d26886edf
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Makefile.PL

  Log Message:
  -----------
  build_requires already has the dependency


  Commit: d9dffa78be53f12dcbeb92680c8ad38276b31a3a
      https://github.com/perl5-dbi/dbi/commit/d9dffa78be53f12dcbeb92680c8ad38276b31a3a
  Author: Joakim <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    A lib/DBI/Test/DBI/Case/attributes/Active.pm
    A lib/DBI/Test/DBI/Case/attributes/ActiveKids.pm
    A lib/DBI/Test/DBI/Case/attributes/CachedKids.pm
    A lib/DBI/Test/DBI/Case/attributes/Executed.pm
    A lib/DBI/Test/DBI/Case/attributes/Kids.pm
    A lib/DBI/Test/DBI/Case/attributes/Type.pm

  Log Message:
  -----------
  Inital test files. To be updated


  Commit: 8ac77f0ba2b5328f9ed32410fea151389f530002
      https://github.com/perl5-dbi/dbi/commit/8ac77f0ba2b5328f9ed32410fea151389f530002
  Author: Joakim <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M lib/DBI/Test/DBI/Case/attributes/ActiveKids.pm
    M lib/DBI/Test/DBI/Case/attributes/Kids.pm
    M lib/DBI/Test/DBI/Case/attributes/Type.pm

  Log Message:
  -----------
  Fixed typo. Test now runs without dying


  Commit: a9bd2f138fd9b72da5d35a83e990d6381de2f30c
      https://github.com/perl5-dbi/dbi/commit/a9bd2f138fd9b72da5d35a83e990d6381de2f30c
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    R lib/DBI/Test/DBI/Case/attributes/Active.pm
    R lib/DBI/Test/DBI/Case/attributes/ActiveKids.pm
    R lib/DBI/Test/DBI/Case/attributes/CachedKids.pm
    R lib/DBI/Test/DBI/Case/attributes/Executed.pm
    R lib/DBI/Test/DBI/Case/attributes/Kids.pm
    R lib/DBI/Test/DBI/Case/attributes/Type.pm

  Log Message:
  -----------
  rename testcases to basename DBI::Test::Case

rename testcases to basename DBI::Test::Case, 'cause it's always prepended


  Commit: 07f7d97cadc25db71df8e73b5384acfbe84fe538
      https://github.com/perl5-dbi/dbi/commit/07f7d97cadc25db71df8e73b5384acfbe84fe538
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M DBI.pm
    M t/70callbacks.t

  Log Message:
  -----------
  Add the `connect_cached.connected` callback.

It is only called for new connections, right after they connect. This is
because the `connected()` method is not called, for whatever reason.


  Commit: 0c429b59e5b65f8a1c4c7795cd9efc4bc9911a26
      https://github.com/perl5-dbi/dbi/commit/0c429b59e5b65f8a1c4c7795cd9efc4bc9911a26
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Changes

  Log Message:
  -----------
  Merge notes


  Commit: 7624a1eea5ba352e92e7857bd05b1aef1a1709ee
      https://github.com/perl5-dbi/dbi/commit/7624a1eea5ba352e92e7857bd05b1aef1a1709ee
  Author: Jens Rehsack <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Makefile.PL

  Log Message:
  -----------
  Fix loading issue without DBI.so


  Commit: a690478be1f9bca399b149d9a268bbcad8870a16
      https://github.com/perl5-dbi/dbi/commit/a690478be1f9bca399b149d9a268bbcad8870a16
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M Changes
    M DBI.pm

  Log Message:
  -----------
  Complete and check merge with master


  Commit: d5bb251c51103d727001c8e09a9d91b66adc49f4
      https://github.com/perl5-dbi/dbi/commit/d5bb251c51103d727001c8e09a9d91b66adc49f4
  Author: H.Merijn Brand - Tux <[email protected]>
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
    M DBI.pm
    M t/70callbacks.t

  Log Message:
  -----------
  Merge branch 'dbi-test-conditional' of github.com:perl5-dbi/dbi into dbi-test-conditional

Conflicts:
	Changes
	DBI.pm


Compare: https://github.com/perl5-dbi/dbi/compare/98586fedb091...d5bb251c5110
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.