Re: DBIT prototype - feedback wanted

On Tue, Feb 18, 2014 at 09:37:10AM +0100, H.Merijn Brand wrote:
> On Mon, 17 Feb 2014 23:37:46 +0000, Tim Bunce <[email protected]>
> wrote:
> 
> BooK, I added you for Test::Database feedback
> 
> > Any feedback?
> > Any feedback at all?
> 
> I'll be verbose (and blond) assuming close to no prior knowledge and
> having the greatest virtue of all: Laziness :)

Perfect! :)

> I will just have to see what the influence of this "too new" YAML::Tiny
> is. Otherwise I will have to nag BooK and Ether
> ____
> Run:
>     cd .../DBI-Test/sandbox/tim
> 
>     rm -rf out* && perl tumbler.pl && prove -j4 -sr out
> --8<---
> % rm -rf out* && perl tumbler.pl && prove -j4 -sr out
> YAML::Tiny failed to classify line 'dbi:CSV::' at /pro/lib/perl5/site_perl/5.18.2/Test/Database/Driver.pm line 103.

That's the "too new" YAML::Tiny Test::Database problem.
I've added a note to the README about that expected warning.

> Can't tell if DBD::Oracle is pure-perl. Loading via DBI::PurePerl failed in an unexpected way: install_driver(Oracle) failed: Can't load '/pro/lib/perl5/site_perl/5.18.2/i686-linux-64int-ld/auto/DBD/Oracle/Oracle.so' for module DBD::Oracle: libnnz12.so: cannot open shared object file: No such file or directory at /pro/lib/perl5/5.18.2/i686-linux-64int-ld/DynaLoader.pm line 190.

I've added filtering for drivers that can't be loaded at all.

> So I need to set up Test::Database. Never actually *used* that before.
> Just tested it for BooK. /me shaves that Yak …
> 
> FWIW: I think "Extend:" should be *before* "Run:"

Perhaps. I'm keen on getting the default experience as smooth as
possible though. Doing the run first gets useful feedback about that,
and avoids the anoying Test::Database config location issue...

> The docs for Test::Database tell me to write ~/.test-database, which I
> did, but running tumbler complains about a missing init file at
> /home/merijn/.local/share/.test-database

I've never been a fan of File::HomeDir, which Test::Database uses.
I added that log message saying what path it was reading in order
to work out what the heck it was doing.  For me, on a mac, it's
using /Users/timbo/Library/Application Support/.test-database' :(

I see Test::Database is using the my_data() method which the
File::HomeDir docs describe as "data that supports an application but
*isn't normally editing* by the user directory should go into my_data."
(Emphasis mine.) So use of my_data() is unfortunate.  Using my_home()
would be more natural for more users.

I'm not sure if I should file a Test::Database bug report on that.


> Can't locate FixtureProvider/CSV.pm in @INC (you may need to install the FixtureProvider::CSV module) (@INC contains: in lib /pro/lib/perl5/site_perl/5.18.2/i686-linux-64int-ld /pro/lib/perl5/site_perl/5.18.2 /pro/lib/perl5/5.18.2/i686-linux-64int-ld /pro/lib/perl5/5.18.2 .) at (eval 141) line 2.
> out/pureperl_gofer/CSV/Default/DBIT_dbh_ro/GetInfo.t .................... Dubious, test returned 1 (wstat 256, 0x100)

No longer an error - it'll now warn and default to FixtureProvider::GenericBase_SQL.

Thanks for the feedback!

More feedback, from you or anyone else, is most welcome.

Tim.