Re: DBI 1.644 cannot be compiled with gcc 14.2.1: dbih_inner()

--Sig_/xl1qd9Z76OxvdhA_8liFysd
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 29 Aug 2024 17:23:46 +0300, Dilyan Palauzov via dbi-dev <dbi-dev@pe=
rl.org> wrote:

> Hello,
>=20
> DBI 1.644 fails to compile with gcc 14.2.1 and perl 5.38.2:

Check out https://github.com/perl5-dbi/dbi/commit/d6e2bf13ac6043f5b0a9a1478=
05b4915bd70e631

We are working very hard to get DBI back in shape after 4=C2=BD years of re=
lative silence.
Changes have been committed to git, but a release did not happen

If you depend on a recent DBI, check out from git.
As releasing is a long process to make sure we did not break new
things, I am not doing releases in haste

> =E2=80=A6
> DBI.xs: In function =E2=80=98dbi_ima_free=E2=80=99:=20
> DBI.xs:250:46: warning: unused parameter =E2=80=98mg=E2=80=99 [-Wunused-p=
arameter]
>   250 | static int dbi_ima_free(pTHX_ SV* sv, MAGIC* mg)
>       |                                       ~~~~~~~^~=20
> In file included from /usr/local/lib/perl5/5.38.2/x86_64-linux-thread-mul=
ti-ld/CORE/perl.h:6227:
> DBI.xs: In function =E2=80=98dbih_inner=E2=80=99:
> /usr/local/lib/perl5/5.38.2/x86_64-linux-thread-multi-ld/CORE/hv.h:541:31=
: error: passing argument 2 of =E2=80=98Perl_hv_common_key_len=E2=80=99 fro=
m in compatible pointer type [-Wincompatible-pointer-types]                =
                                                                 =20
>   541 |     ((SV**) hv_common_key_len((hv), (key), (klen), (lval)        =
       \
>       |                               ^~~~=20
>       |                               |
>       |                               SV * {aka struct sv *}
> /usr/local/lib/perl5/5.38.2/x86_64-linux-thread-multi-ld/CORE/embed.h:293=
:78: note: in definition of macro =E2=80=98hv_common_key_len=E2=80=99
>   293 | # define hv_common_key_len(a,b,c,d,e,f)         Perl_hv_common_ke=
y_len(aTHX_ a,b,c,d,e,f)
>       |                                                                  =
            ^
>=20
>=20
> While the error message is =E2=80=98argument 2", the ^~~~ points to the f=
irst argument of hv_common_hey_len (and to the second of Perl_hv_common_key=
_len)
>
>   Dilyan

--=20
H.Merijn Brand  https://tux.nl   Perl Monger   http://amsterdam.pm.org/
using perl5.00307 .. 5.37        porting perl5 on HP-UX, AIX, and Linux
https://tux.nl/email.html http://qa.perl.org https://www.test-smoke.org
                          =20

--Sig_/xl1qd9Z76OxvdhA_8liFysd
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEGolmczWuFi3lJEbAA6FHoT5dwJgFAmbQlZoACgkQA6FHoT5d
wJhUHQgAqN8H3GT/8i8Z75Ymdgj2V/irWPhkSdPVpP/3b0Q5NBlnUUZcUItnARuk
BOqeb+jn2zdZ2vXFo8vJawtpabXx6IT8y6qcqqoCRAR/e5lGkYx7wGqIfMUpXjXk
0Dc2R0AijsooS7HDK6SRYKGIBrhXl+VXO6tGRbJPlLxr2zrEXiw0rROtOcPi2tYk
egvLkSXxOLzfabuguid05FeDCg7N3H2DOqmxwOb2LULe6p+vK3ZuQ0/UiEI1vhcW
ahOU1HPj42v7Ng5xyZA1j0P2LCbvmbQDhBlw86n/wRqsDnSA2WrLrhrsYxr2Sxt6
8HJBVAnIU7rMCvD2W0n7uzii8KHaTA==
=gxUR
-----END PGP SIGNATURE-----

--Sig_/xl1qd9Z76OxvdhA_8liFysd--