Re: Prefixification and relative directories (Re: any 5.10.1 showstoppers?)

On Wed, Aug 05, 2009 at 12:37:29AM -0700, Michael G Schwern wrote:
> Oh goodie, another special case for prefixificaiton.
> 
> MakeMaker does not prefix relative directories.  The reasoning is lost,
> there's just this:
> 
> -----------------------------------------------
> commit 2011f6497b6a2f94ae670bb3208d7bff80dbad33
> Author: Michael G Schwern <[email protected]>
> Date:   Tue Nov 4 00:13:05 2003 +0000
> 
>         - Fixing minor bug in VMS prefixification logic when PREFIX was not set
>           by the user.
>         - Fixing potential bug in prefixification for relative directories
> 
>     Basically, we check $self->{ARGS}{PREFIX} first to see if prefixification
>     is necessary.  We also don't bother to prefixify relative directories.
> 
> 
>     git-svn-id: http://svn.schwern.org/repos/CPAN/ExtUtils-MakeMaker/trunk@1812
> 8151f2b9-fde8-0310-94fd-f048d12aab9e
> -----------------------------------------------
> 
> Encountering a perl with a relative @INC was never considered.  In fact, it
> seems the tests are being run while Perl has an @INC that includes things
> which are not even valid paths!  This doesn't seem like such a hot idea.
> 
> Anyhow, I don't remember why prefixification didn't apply to relative
> directories so I'll just remove that.
> 
> I've committed it and pushed out 6.55_02.

I tried applying it to blead, but got lots of test failures in
lib/ExtUtils/t/00compile.t:

Test Summary Report
-------------------
../lib/ExtUtils/t/00compile.t                                  (Wstat: 3840 Tests: 950 Failed: 15)
  Failed tests:  23, 87, 197, 269, 385, 387, 391, 393, 437
                533, 593, 687, 735, 797, 801


$ cd t
$ ./TEST -v ../lib/ExtUtils/t/00compile.t
t/../lib/ExtUtils/t/00compile....1..950
ok 1
ok 2 # skip Test::Pod not installed
ok 3
ok 4 # skip Test::Pod not installed
ok 5
ok 6 # skip Test::Pod not installed
ok 7
ok 8 # skip Test::Pod not installed
ok 9
ok 10 # skip Test::Pod not installed
ok 11
ok 12 # skip Test::Pod not installed
ok 13
ok 14 # skip Test::Pod not installed
ok 15
ok 16 # skip Test::Pod not installed
ok 17
ok 18 # skip Test::Pod not installed
ok 19
ok 20 # skip Test::Pod not installed
ok 21
ok 22 # skip Test::Pod not installed
not ok 23
#   Failed test at ../lib/ExtUtils/t/00compile.t line 36.
# require autodie/t/lib/autodie/test/au.pm failed.
# Can't locate autodie/test/au/exception.pm in @INC (@INC contains: . ../lib lib) at autodie/t/lib/autodie/test/au.pm line 7.
# BEGIN failed--compilation aborted at autodie/t/lib/autodie/test/au.pm line 7.
# Compilation failed in require at ../lib/ExtUtils/t/00compile.t line 36.
FAILED at test 23
Failed 1 test out of 1, 0.00% okay.
	../lib/ExtUtils/t/00compile.t

$ grep au.pm ../MANIFEST 
lib/autodie/t/lib/autodie/test/au.pm		autodie - Austrlaian helper

-- 
Spock (or Data) is fired from his high-ranking position for not being able
to understand the most basic nuances of about one in three sentences that
anyone says to him.
    -- Things That Never Happen in "Star Trek" #19